linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Thilo Cestonaro <thilo@cestona.ro>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0489:e031]
Date: Mon, 09 Jan 2012 11:39:44 -0800	[thread overview]
Message-ID: <1326137984.6454.152.camel@aeonflux> (raw)
In-Reply-To: <4F0ACADF.1060906@cestona.ro>

Hi Thilo,

> output of usb-devices:
> T:  Bus=02 Lev=02 Prnt=02 Port=03 Cnt=03 Dev#=  5 Spd=12  MxCh= 0
> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0489 ProdID=e031 Rev=01.12
> S:  Manufacturer=Broadcom Corp
> S:  Product=BCM20702A0
> S:  SerialNumber=EC55F9EADE09
> C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

you need to signed-of-by your patches.

> ---
>   drivers/bluetooth/btusb.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 55ac349..07622141a 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = {
>       { USB_DEVICE(0x0c10, 0x0000) },
> 
>       /* Broadcom BCM20702A0 */
> +    { USB_DEVICE(0x0489, 0xe031) },
>       { USB_DEVICE(0x0a5c, 0x21e3) },
>       { USB_DEVICE(0x413c, 0x8197) },

And please follow the coding style. This needs to be a tab here.

Regards

Marcel



  reply	other threads:[~2012-01-09 19:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 11:09 [PATCH] Bluetooth: Add support for BCM20702A0 [0489:e031] Thilo Cestonaro
2012-01-09 19:39 ` Marcel Holtmann [this message]
2012-01-10  7:12   ` Harvey
2012-01-10  8:11     ` Marcel Holtmann
2012-01-10 12:55       ` Harvey
2012-01-10 16:51         ` Marcel Holtmann
2012-01-11  8:15           ` Harvey
2012-01-11 10:35             ` Marcel Holtmann
2012-01-11 10:49               ` Harvey
2012-01-11 10:56                 ` Marcel Holtmann
2012-01-11 11:12                   ` Harvey
2012-01-14 13:27               ` David Strobach
2012-01-15 10:58                 ` Johan Hedberg
2012-01-15 11:21                   ` David Strobach
2012-01-11  7:43   ` Thilo Cestonaro
2012-01-11 10:34     ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2012-08-27 19:56 thilo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326137984.6454.152.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=thilo@cestona.ro \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).