From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com
Subject: Re: [PATCH 2/5] Bluetooth: Set P-bit for SREJ frame only if there are I-frames to ack
Date: Mon, 09 Jan 2012 11:48:49 -0800 [thread overview]
Message-ID: <1326138529.6454.159.camel@aeonflux> (raw)
In-Reply-To: <1326122391-8438-3-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
> SREJ frame with P-bit set acknowledges I-frames numbered up to
> (ReqSeq - 1). Also stop ack timer before sending SREJ with P-bit set,
> otherwise I-frames would be acknowledged twice.
some notes about the qualification test cases and a bit more verbose
human explanation is expected here as well.
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> net/bluetooth/l2cap_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Regards
Marcel
next prev parent reply other threads:[~2012-01-09 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 15:19 [PATCH 0/5] ERTM improvements Szymon Janc
2012-01-09 15:19 ` [PATCH 1/5] Bluetooth: Make l2cap_clear_timer return if timer was running or not Szymon Janc
2012-01-09 19:47 ` Marcel Holtmann
2012-01-10 8:01 ` Szymon Janc
2012-01-10 8:13 ` Marcel Holtmann
2012-01-09 15:19 ` [PATCH 2/5] Bluetooth: Set P-bit for SREJ frame only if there are I-frames to ack Szymon Janc
2012-01-09 19:48 ` Marcel Holtmann [this message]
2012-01-09 15:19 ` [PATCH 3/5] Bluetooth: Clear ack_timer when sending ack Szymon Janc
2012-01-09 19:50 ` Marcel Holtmann
2012-01-10 9:04 ` Szymon Janc
2012-01-10 9:36 ` Marcel Holtmann
2012-01-09 15:19 ` [PATCH 4/5] Bluetooth: Don't send RNR immediately when entering local busy Szymon Janc
2012-01-09 19:52 ` Marcel Holtmann
2012-01-09 15:19 ` [PATCH 5/5] Bluetooth: Drop L2CAP chan reference if ERTM ack_timer fired Szymon Janc
2012-01-09 19:52 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326138529.6454.159.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=kanak.gupta@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).