* [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization
@ 2012-01-11 14:30 jaganath.k
2012-01-11 14:45 ` Johan Hedberg
0 siblings, 1 reply; 4+ messages in thread
From: jaganath.k @ 2012-01-11 14:30 UTC (permalink / raw)
To: linux-bluetooth; +Cc: jaganath.k
From: jaganath.k <jaganath.k@samsung.com>
Transfer is registered with id as cid, but authorize method
is called with id as pointer to obex session structure
---
src/manager.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/manager.c b/src/manager.c
index 846f8a0..87010c4 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -539,7 +539,7 @@ int manager_request_authorization(struct obex_session *os, int32_t time,
if (err < 0)
return err;
- path = g_strdup_printf("/transfer%u", GPOINTER_TO_UINT(os));
+ path = g_strdup_printf("/transfer%u", os->id);
msg = dbus_message_new_method_call(agent->bus_name, agent->path,
"org.openobex.Agent", "Authorize");
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization
2012-01-11 14:30 [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization jaganath.k
@ 2012-01-11 14:45 ` Johan Hedberg
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hedberg @ 2012-01-11 14:45 UTC (permalink / raw)
To: jaganath.k; +Cc: linux-bluetooth
Hi Jaganath,
On Wed, Jan 11, 2012, jaganath.k@samsung.com wrote:
> From: jaganath.k <jaganath.k@samsung.com>
>
> Transfer is registered with id as cid, but authorize method
> is called with id as pointer to obex session structure
> ---
> src/manager.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Both of these patches look fine to me, but you need to fix your git
author name. Once you've done that please resend the patches.
I also noticed that I've by mistake already applied another patch from
you in December with the same bogus author name, so you'll end up
getting your own entry in our infamous .mailmap file.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization
@ 2012-01-11 15:03 Jaganath Kanakkassery
2012-01-11 15:08 ` Johan Hedberg
0 siblings, 1 reply; 4+ messages in thread
From: Jaganath Kanakkassery @ 2012-01-11 15:03 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaganath Kanakkassery
Transfer is registered with id as cid, but authorize method
is called with id as pointer to obex session structure
---
src/manager.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/manager.c b/src/manager.c
index 846f8a0..87010c4 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -539,7 +539,7 @@ int manager_request_authorization(struct obex_session *os, int32_t time,
if (err < 0)
return err;
- path = g_strdup_printf("/transfer%u", GPOINTER_TO_UINT(os));
+ path = g_strdup_printf("/transfer%u", os->id);
msg = dbus_message_new_method_call(agent->bus_name, agent->path,
"org.openobex.Agent", "Authorize");
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-11 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 14:30 [PATCH obexd 1/2] Fix incorrect transfer path id during request authorization jaganath.k
2012-01-11 14:45 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2012-01-11 15:03 Jaganath Kanakkassery
2012-01-11 15:08 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).