linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] bluetooth.h: fix compile issue when using in C++
Date: Mon, 16 Jan 2012 11:11:55 +0100	[thread overview]
Message-ID: <1326708715.3360.135.camel@pohly-mobl1.fritz.box> (raw)

The compiler error is:
 /usr/include/bluetooth/bluetooth.h::131:9: error: invalid conversion from 'void*' to 'bt_get_le64(void*)::<anonymous struct>*'
 ...

The reason is that C++, in contrast to C, does not allow conversion of
void * to anything, and this code gets compiled as C++ when the app is
written in C++. The macro with the assignment itself is older, but only
recent Bluez starts to use it in inline functions, thus triggering the
problem.

This patch keeps the "struct __attribute__((packed))" magic and merely
changes the typecast so that it works in C and C++. Like the existing
macro this patch relies on support for typeof.
---
 lib/bluetooth.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bluetooth.h b/lib/bluetooth.h
index 5bd4f03..2fee4ac 100644
--- a/lib/bluetooth.h
+++ b/lib/bluetooth.h
@@ -113,7 +113,7 @@ enum {
 ({						\
 	struct __attribute__((packed)) {	\
 		typeof(*(ptr)) __v;		\
-	} *__p = (void *) (ptr);		\
+	} *__p = (typeof(__p)) (ptr);		\
 	__p->__v;				\
 })
 
@@ -121,7 +121,7 @@ enum {
 do {						\
 	struct __attribute__((packed)) {	\
 		typeof(*(ptr)) __v;		\
-	} *__p = (void *) (ptr);		\
+	} *__p = (typeof(__p)) (ptr);		\
 	__p->__v = (val);			\
 } while(0)
 
-- 
1.7.7.3



             reply	other threads:[~2012-01-16 10:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 10:11 Patrick Ohly [this message]
2012-03-04 23:27 ` [PATCH] bluetooth.h: fix compile issue when using in C++ Marcel Holtmann
2012-03-05  7:33   ` Patrick Ohly
     [not found]     ` <CAOcK=CNZofxZtUp4Zh5eiGMM_TYrbGOwseA3tcwAnAFDvLEFxg@mail.gmail.com>
2012-03-05 13:12       ` Patrick Ohly
2012-03-05 14:53         ` Markus Rathgeb
2012-07-27 16:38         ` W. Trevor King
2012-08-17  5:18         ` W. Trevor King
2012-08-27 23:40           ` Johan Hedberg
2012-09-05 17:27             ` Pacho Ramos
2012-09-05 17:56               ` Pacho Ramos
2012-03-05 20:06   ` Lucas De Marchi
2012-03-08 13:22     ` Markus Rathgeb
2012-03-08 17:51       ` Marcel Holtmann
2012-03-08 20:59         ` Markus Rathgeb
2012-03-09 10:52           ` Markus Rathgeb
  -- strict thread matches above, loose matches on Subject: below --
2012-03-03 17:15 Markus Rathgeb
2012-07-29  7:52 Pacho Ramos
2012-08-01 14:41 ` Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326708715.3360.135.camel@pohly-mobl1.fritz.box \
    --to=patrick.ohly@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).