From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH BlueZ 2/3] Fix g_strndup() call for EIR name
Date: Tue, 17 Jan 2012 12:18:01 -0400 [thread overview]
Message-ID: <1326817082-6787-2-git-send-email-anderson.lizardo@openbossa.org> (raw)
In-Reply-To: <1326817082-6787-1-git-send-email-anderson.lizardo@openbossa.org>
Use the actual string length (without the trailing NUL terminator) for
g_strndup(), because it allocates and inserts a trailing NUL byte.
---
src/eir.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/eir.c b/src/eir.c
index ff50cf8..96aa763 100644
--- a/src/eir.c
+++ b/src/eir.c
@@ -169,8 +169,7 @@ int eir_parse(struct eir_data *eir, uint8_t *eir_data, uint8_t eir_len)
g_free(eir->name);
- eir->name = g_strndup((char *) &eir_data[2],
- field_len - 1);
+ eir->name = g_strndup((char *) &eir_data[2], name_len);
eir->name_complete = eir_data[1] == EIR_NAME_COMPLETE;
break;
}
--
1.7.0.4
next prev parent reply other threads:[~2012-01-17 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 16:18 [PATCH BlueZ 1/3] Fix wrong offset in EIR name parsing Anderson Lizardo
2012-01-17 16:18 ` Anderson Lizardo [this message]
2012-01-17 16:18 ` [PATCH BlueZ 3/3] Fix not showing name if first EIR has no name info Anderson Lizardo
2012-01-17 19:43 ` Johan Hedberg
2012-01-17 19:58 ` Anderson Lizardo
2012-01-17 19:35 ` [PATCH BlueZ 1/3] Fix wrong offset in EIR name parsing Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326817082-6787-2-git-send-email-anderson.lizardo@openbossa.org \
--to=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).