linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Scott James Remnant <scott@netsplit.com>
To: linux-bluetooth@vger.kernel.org
Cc: keybuk@chromium.org, Scott James Remnant <scott@netsplit.com>
Subject: [RFC PATCH 0/3] Generate PIN for keyboards inside bluetoothd
Date: Fri, 20 Jan 2012 15:05:41 -0800	[thread overview]
Message-ID: <1327100744-28782-1-git-send-email-scott@netsplit.com> (raw)

Here's a first pass of handling the HID profile recommendation for
pairing keyboards inside bluetoothd, rather than expecting the UI
Agent to deal with it.

This requires agents implement a new DisplayPinCode method, since
the existing DisplayPasskey method expects a numeric and PIN Codes
are UTF-8 strings.

As well as general type-stricty-ness, the method allows the UI to
distinguish between a Bluetooth 2.0 keyboard (ie. all of them) and
future Bluetooth 2.1 keyboards implementing SSP (for which there may
be keypress notification). UIs might want to display them slightly
differently (OS X does, and UI developers tend to just copy that).

That said, the PINs generated here are 6-digit 0-padded numerics
since that's probably less confusing for users and there are
Bluetooth numeric keypads out there that can't do non-numerics.

Scott James Remnant (3):
  lib: add header of device class constants
  agent: add DisplayPinCode method
  Implement HID profile recommendation for keyboards

 Makefile.am       |    2 +-
 doc/agent-api.txt |   12 +++++
 lib/bt_ids.h      |  133 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/agent.c       |   27 +++++++++++
 src/agent.h       |    2 +
 src/device.c      |   24 ++++++---
 src/device.h      |    5 +-
 src/event.c       |   32 +++++++++++--
 test/simple-agent |    5 ++
 9 files changed, 226 insertions(+), 16 deletions(-)
 create mode 100644 lib/bt_ids.h

-- 
1.7.7.3


             reply	other threads:[~2012-01-20 23:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 23:05 Scott James Remnant [this message]
2012-01-20 23:05 ` [RFC PATCH 1/3] lib: add header of device class constants Scott James Remnant
2012-01-21 16:30   ` Marcel Holtmann
2012-01-21 17:29     ` Scott James Remnant
2012-01-20 23:05 ` [RFC PATCH 2/3] agent: add DisplayPinCode method Scott James Remnant
2012-01-21 16:36   ` Marcel Holtmann
2012-01-23  6:08     ` Scott James Remnant
2012-01-20 23:05 ` [RFC PATCH 3/3] Implement HID profile recommendation for keyboards Scott James Remnant
2012-01-23 12:14 ` [RFC PATCH 0/3] Generate PIN for keyboards inside bluetoothd Bastien Nocera
2012-01-23 15:37   ` Scott James Remnant
2012-01-23 16:03     ` Bastien Nocera
2012-01-23 16:10       ` Scott James Remnant
2012-01-23 16:24         ` Bastien Nocera
2012-01-23 16:26           ` Scott James Remnant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327100744-28782-1-git-send-email-scott@netsplit.com \
    --to=scott@netsplit.com \
    --cc=keybuk@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).