From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Remove old unused lock
Date: Mon, 23 Jan 2012 10:19:12 +0100 [thread overview]
Message-ID: <1327310352.1955.93.camel@aeonflux> (raw)
In-Reply-To: <1327309863-12696-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> include/net/bluetooth/l2cap.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index f6d5134..c21e37a 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -544,7 +544,6 @@ struct l2cap_conn {
> struct smp_chan *smp_chan;
>
> struct list_head chan_l;
> - struct mutex chan_lock;
> };
>
> #define L2CAP_INFO_CL_MTU_REQ_SENT 0x01
so if this one is not used, how do we protect any changes at all. I am
kinda nervous now that our L2CAP is broken. Please start looking into
fixing this and send a patch series that I can review as a whole and see
how it progresses.
Regards
Marcel
next prev parent reply other threads:[~2012-01-23 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 9:11 [PATCH] Bluetooth: Remove old unused lock Emeltchenko Andrei
2012-01-23 9:19 ` Marcel Holtmann [this message]
2012-01-23 22:08 ` Ulisses Furquim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327310352.1955.93.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).