From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ] audio: fix not disabling local a2dp endpoints when unix socket is disabled
Date: Thu, 26 Jan 2012 23:39:02 +0200 [thread overview]
Message-ID: <1327613942-23745-1-git-send-email-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Local endpoints can only be used when unix socket API is available
---
audio/a2dp.c | 15 +++++++--------
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/audio/a2dp.c b/audio/a2dp.c
index c4cdc62..2eebe6b 100644
--- a/audio/a2dp.c
+++ b/audio/a2dp.c
@@ -1441,9 +1441,9 @@ static struct a2dp_server *find_server(GSList *list, const bdaddr_t *src)
int a2dp_register(DBusConnection *conn, const bdaddr_t *src, GKeyFile *config)
{
- int sbc_srcs = 1, sbc_sinks = 1;
+ int sbc_srcs = 0, sbc_sinks = 0;
int mpeg12_srcs = 0, mpeg12_sinks = 0;
- gboolean source = TRUE, sink = FALSE, socket = TRUE;
+ gboolean source = TRUE, sink = FALSE, socket = FALSE;
gboolean delay_reporting = FALSE;
char *str;
GError *err = NULL;
@@ -1463,6 +1463,8 @@ int a2dp_register(DBusConnection *conn, const bdaddr_t *src, GKeyFile *config)
source = TRUE;
if (strstr(str, "Source"))
sink = TRUE;
+ if (strstr(str, "Socket"))
+ socket = TRUE;
g_free(str);
}
@@ -1482,18 +1484,14 @@ int a2dp_register(DBusConnection *conn, const bdaddr_t *src, GKeyFile *config)
}
/* Don't register any local sep if Socket is disabled */
- if (socket == FALSE) {
- sbc_srcs = 0;
- sbc_sinks = 0;
- mpeg12_srcs = 0;
- mpeg12_sinks = 0;
+ if (socket == FALSE)
goto proceed;
- }
str = g_key_file_get_string(config, "A2DP", "SBCSources", &err);
if (err) {
DBG("audio.conf: %s", err->message);
g_clear_error(&err);
+ sbc_srcs = 1;
} else {
sbc_srcs = atoi(str);
g_free(str);
@@ -1512,6 +1510,7 @@ int a2dp_register(DBusConnection *conn, const bdaddr_t *src, GKeyFile *config)
if (err) {
DBG("audio.conf: %s", err->message);
g_clear_error(&err);
+ sbc_sinks = 1;
} else {
sbc_sinks = atoi(str);
g_free(str);
--
1.7.7.6
next reply other threads:[~2012-01-26 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 21:39 Luiz Augusto von Dentz [this message]
2012-01-27 10:31 ` [PATCH BlueZ] audio: fix not disabling local a2dp endpoints when unix socket is disabled Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327613942-23745-1-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).