linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ulisses Furquim <ulisses@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi
Subject: Re: [PATCH v4 1/2] Bluetooth: Remove usage of __cancel_delayed_work()
Date: Mon, 30 Jan 2012 13:29:56 -0800	[thread overview]
Message-ID: <1327958996.1955.162.camel@aeonflux> (raw)
In-Reply-To: <1327955189-4604-1-git-send-email-ulisses@profusion.mobi>

Hi Ulisses,

> __cancel_delayed_work() is being used in some paths where we cannot
> sleep waiting for the delayed work to finish. However, that function
> might return while the timer is running and the work will be queued
> again. Replace the calls with safer cancel_delayed_work() version
> which spins until the timer handler finishes on other CPUs and
> cancels the delayed work.
> 
> Signed-off-by: Ulisses Furquim <ulisses@profusion.mobi>
> ---

I have the feeling that I already looked at this patch before. And given
that it is v4, that might be true actually ;)

Use the space between --- and diffstat to have some small changelog so I
know what was different to the previous version.

>  include/net/bluetooth/l2cap.h |    4 ++--
>  net/bluetooth/l2cap_core.c    |    6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  parent reply	other threads:[~2012-01-30 21:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 20:26 [PATCH v4 1/2] Bluetooth: Remove usage of __cancel_delayed_work() Ulisses Furquim
2012-01-30 20:26 ` [PATCH v4 2/2] Bluetooth: Fix possible use after free in delete path Ulisses Furquim
2012-01-30 21:30   ` Marcel Holtmann
2012-01-30 21:29 ` Marcel Holtmann [this message]
2012-01-30 21:42   ` [PATCH v4 1/2] Bluetooth: Remove usage of __cancel_delayed_work() Ulisses Furquim
2012-01-30 22:27 ` Johan Hedberg
2012-03-01  9:10 ` Andrei Emeltchenko
2012-03-01 12:23   ` Andrei Emeltchenko
2012-03-01 13:34   ` Ulisses Furquim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327958996.1955.162.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    --cc=ulisses@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).