From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 4/6] Bluetooth: Add hci_le_scan()
Date: Mon, 30 Jan 2012 13:41:43 -0800 [thread overview]
Message-ID: <1327959703.1955.169.camel@aeonflux> (raw)
In-Reply-To: <1327531949-29463-5-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
> We are not supposed to block in start_discovery() because
> start_discovery code is running in write() syscall context
> and this would block the write operation on the mgmt socket.
> This way, we cannot directly call hci_do_le_scan() to scan
> LE devices in start_discovery(). To overcome this issue a
> derefered work (hdev->le_scan) was created so we can properly
> call hci_do_le_scan().
>
> The helper function hci_le_scan() simply set LE scan parameters
> and queue hdev->le_scan work. The work is queued on system_long_wq
> since it can sleep for a few seconds in the worst case (timeout).
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> include/net/bluetooth/hci_core.h | 12 ++++++++++++
> net/bluetooth/hci_core.c | 34 ++++++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+), 0 deletions(-)
so I am fine with this one, but we might need to make this one generic
as well (if possible).
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-01-30 21:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 22:52 [PATCH v3 0/6] MGMT Start Discovery command LE-Only Support Andre Guedes
2012-01-25 22:52 ` [PATCH v3 1/6] Bluetooth: LE scan should send Discovering events Andre Guedes
2012-01-30 21:35 ` Marcel Holtmann
2012-01-31 13:41 ` Andre Guedes
2012-01-31 15:12 ` Marcel Holtmann
2012-01-25 22:52 ` [PATCH v3 2/6] Bluetooth: Add helper functions to send LE scan commands Andre Guedes
2012-01-25 22:52 ` [PATCH v3 3/6] Bluetooth: Add hci_do_le_scan() Andre Guedes
2012-01-30 21:38 ` Marcel Holtmann
2012-01-30 23:22 ` Andre Guedes
2012-01-31 0:51 ` Marcel Holtmann
2012-01-31 13:42 ` Andre Guedes
2012-01-25 22:52 ` [PATCH v3 4/6] Bluetooth: Add hci_le_scan() Andre Guedes
2012-01-30 21:41 ` Marcel Holtmann [this message]
2012-01-25 22:52 ` [PATCH v3 5/6] Bluetooth: MGMT start discovery LE-Only support Andre Guedes
2012-01-26 12:55 ` Anderson Lizardo
2012-01-26 13:05 ` Andre Guedes
2012-01-30 21:44 ` Marcel Holtmann
2012-01-31 13:44 ` Andre Guedes
2012-01-25 22:52 ` [PATCH v3 6/6] Bluetooth: Fix indentation Andre Guedes
2012-01-30 21:45 ` Marcel Holtmann
2012-01-31 13:45 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327959703.1955.169.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).