From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
anderson.lizardo@openbossa.org
Subject: Re: [PATCH 2/4 v2] Bluetooth: Remove hci_dev->driver_data
Date: Mon, 30 Jan 2012 13:57:35 -0800 [thread overview]
Message-ID: <1327960655.1955.179.camel@aeonflux> (raw)
In-Reply-To: <1327683670-3111-1-git-send-email-dh.herrmann@googlemail.com>
Hi David,
> The linux device model provides dev_set/get_drvdata so we can use this
> to save private driver data.
> This also removes several unnecessary casts.
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> v2: Fixed a bug spotted by Anderson Lizardo. I checked the variables in
> btmrvl_main.c in the wrong order.
>
> drivers/bluetooth/bfusb.c | 10 +++++-----
> drivers/bluetooth/bluecard_cs.c | 12 ++++++------
> drivers/bluetooth/bpa10x.c | 18 +++++++++---------
> drivers/bluetooth/bt3c_cs.c | 6 +++---
> drivers/bluetooth/btmrvl_debugfs.c | 26 ++++++++++++--------------
> drivers/bluetooth/btmrvl_main.c | 11 ++++++-----
> drivers/bluetooth/btsdio.c | 10 +++++-----
> drivers/bluetooth/btuart_cs.c | 6 +++---
> drivers/bluetooth/btusb.c | 28 ++++++++++++++--------------
> drivers/bluetooth/btwilink.c | 8 ++++----
> drivers/bluetooth/dtl1_cs.c | 6 +++---
> drivers/bluetooth/hci_ldisc.c | 6 +++---
> drivers/bluetooth/hci_vhci.c | 8 ++++----
> include/net/bluetooth/hci_core.h | 11 ++++++++++-
> 14 files changed, 87 insertions(+), 79 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-01-30 21:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 15:47 [PATCH 0/4] Integrate better device support David Herrmann
2012-01-27 15:47 ` [PATCH 1/4] Bluetooth: Introduce to_hci_dev() David Herrmann
2012-01-30 21:55 ` Marcel Holtmann
2012-01-27 15:47 ` [PATCH 2/4] Bluetooth: Remove hci_dev->driver_data David Herrmann
2012-01-27 16:51 ` Anderson Lizardo
2012-01-27 16:56 ` David Herrmann
2012-01-27 17:01 ` [PATCH 2/4 v2] " David Herrmann
2012-01-30 21:57 ` Marcel Holtmann [this message]
2012-01-27 15:47 ` [PATCH 3/4] Bluetooth: Introduce to_hci_conn David Herrmann
2012-01-27 17:01 ` Andrei Emeltchenko
2012-01-27 17:20 ` David Herrmann
2012-01-30 21:37 ` Ulisses Furquim
2012-01-30 21:59 ` Marcel Holtmann
2012-01-27 15:47 ` [PATCH 4/4] Bluetooth: Use proper datatypes in release-callbacks David Herrmann
2012-01-30 22:00 ` Marcel Holtmann
2012-02-06 12:34 ` [PATCH 0/4] Integrate better device support Andrei Emeltchenko
2012-02-06 14:03 ` David Herrmann
2012-02-09 21:12 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327960655.1955.179.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=dh.herrmann@googlemail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).