From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com
Subject: Re: [PATCH 3/4] Bluetooth: Introduce to_hci_conn
Date: Mon, 30 Jan 2012 13:59:56 -0800 [thread overview]
Message-ID: <1327960796.1955.181.camel@aeonflux> (raw)
In-Reply-To: <1327679246-2667-4-git-send-email-dh.herrmann@googlemail.com>
Hi David,
> This avoids using the dev_set/get_drvdata() functions to retrieve a
> pointer to our own structure. We can use simple pointer arithmetic here.
> The drvdata field is actually not needed by any other code-path but this
> makes the code more consistent with hci_dev.
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_sysfs.c | 10 ++++------
> 2 files changed, 5 insertions(+), 6 deletions(-)
I read through the comment and I am fine with to_hci_conn.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-01-30 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 15:47 [PATCH 0/4] Integrate better device support David Herrmann
2012-01-27 15:47 ` [PATCH 1/4] Bluetooth: Introduce to_hci_dev() David Herrmann
2012-01-30 21:55 ` Marcel Holtmann
2012-01-27 15:47 ` [PATCH 2/4] Bluetooth: Remove hci_dev->driver_data David Herrmann
2012-01-27 16:51 ` Anderson Lizardo
2012-01-27 16:56 ` David Herrmann
2012-01-27 17:01 ` [PATCH 2/4 v2] " David Herrmann
2012-01-30 21:57 ` Marcel Holtmann
2012-01-27 15:47 ` [PATCH 3/4] Bluetooth: Introduce to_hci_conn David Herrmann
2012-01-27 17:01 ` Andrei Emeltchenko
2012-01-27 17:20 ` David Herrmann
2012-01-30 21:37 ` Ulisses Furquim
2012-01-30 21:59 ` Marcel Holtmann [this message]
2012-01-27 15:47 ` [PATCH 4/4] Bluetooth: Use proper datatypes in release-callbacks David Herrmann
2012-01-30 22:00 ` Marcel Holtmann
2012-02-06 12:34 ` [PATCH 0/4] Integrate better device support Andrei Emeltchenko
2012-02-06 14:03 ` David Herrmann
2012-02-09 21:12 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327960796.1955.181.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=dh.herrmann@googlemail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox