linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btusb: Remove device lock on release
@ 2012-01-27 16:37 David Herrmann
  2012-01-30 22:01 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: David Herrmann @ 2012-01-27 16:37 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: johan.hedberg, marcel, David Herrmann

Recently we changed the way how we release driver-data. A driver is now
responsible of destroying the data so we no longer need the device lock
on deinitialization in btusb driver.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 drivers/bluetooth/btusb.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 0de3f5e..0a06d75 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1078,9 +1078,6 @@ static void btusb_disconnect(struct usb_interface *intf)
 		return;
 
 	hdev = data->hdev;
-
-	hci_dev_hold(hdev);
-
 	usb_set_intfdata(data->intf, NULL);
 
 	if (data->isoc)
@@ -1093,8 +1090,6 @@ static void btusb_disconnect(struct usb_interface *intf)
 	else if (data->isoc)
 		usb_driver_release_interface(&btusb_driver, data->isoc);
 
-	hci_dev_put(hdev);
-
 	hci_free_dev(hdev);
 	kfree(data);
 }
-- 
1.7.8.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btusb: Remove device lock on release
  2012-01-27 16:37 [PATCH] Bluetooth: btusb: Remove device lock on release David Herrmann
@ 2012-01-30 22:01 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2012-01-30 22:01 UTC (permalink / raw)
  To: David Herrmann; +Cc: linux-bluetooth, johan.hedberg

Hi David,

> Recently we changed the way how we release driver-data. A driver is now
> responsible of destroying the data so we no longer need the device lock
> on deinitialization in btusb driver.
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
>  drivers/bluetooth/btusb.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-30 22:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-27 16:37 [PATCH] Bluetooth: btusb: Remove device lock on release David Herrmann
2012-01-30 22:01 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).