* [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry()
@ 2012-01-31 2:31 Andre Guedes
2012-01-31 4:51 ` Marcel Holtmann
2012-01-31 6:19 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Andre Guedes @ 2012-01-31 2:31 UTC (permalink / raw)
To: linux-bluetooth; +Cc: andre.guedes, Andre Guedes
This function is not called in interrupt context anymore, so it
should use GFP_KERNEL to allocate memory.
Signed-off-by: Andre Guedes <aguedespe@gmail.com>
---
net/bluetooth/hci_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 91166db..45e2d2a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1553,7 +1553,7 @@ int hci_add_adv_entry(struct hci_dev *hdev,
if (hci_find_adv_entry(hdev, &ev->bdaddr))
return 0;
- entry = kzalloc(sizeof(*entry), GFP_ATOMIC);
+ entry = kzalloc(sizeof(*entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry()
2012-01-31 2:31 [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry() Andre Guedes
@ 2012-01-31 4:51 ` Marcel Holtmann
2012-01-31 6:19 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2012-01-31 4:51 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth, andre.guedes
Hi Andre,
> This function is not called in interrupt context anymore, so it
> should use GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <aguedespe@gmail.com>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry()
2012-01-31 2:31 [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry() Andre Guedes
2012-01-31 4:51 ` Marcel Holtmann
@ 2012-01-31 6:19 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2012-01-31 6:19 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth, andre.guedes
Hi Andre,
On Mon, Jan 30, 2012, Andre Guedes wrote:
> This function is not called in interrupt context anymore, so it
> should use GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <aguedespe@gmail.com>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
The patch has been applied to my bluetooth-next tree. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-31 6:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-31 2:31 [PATCH] Bluetooth: Use GFP_KERNEL in hci_add_adv_entry() Andre Guedes
2012-01-31 4:51 ` Marcel Holtmann
2012-01-31 6:19 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).