From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFCv2 04/10] Bluetooth: Revert to mutexes from RCU list
Date: Fri, 03 Feb 2012 08:06:29 -0800 [thread overview]
Message-ID: <1328285189.2062.39.camel@aeonflux> (raw)
In-Reply-To: <1328279789-10870-5-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Usage of RCU list looks not reasonalbe for a number of reasons:
> our code sleep and we have to use socket spinlocks, some parts
> of code are updaters thus we need to use mutexes anyway.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/l2cap_core.c | 110 ++++++++++++++++++++++---------------------
> 1 files changed, 56 insertions(+), 54 deletions(-)
I don't see anything wrong with this patch, but I am waiting for Ulisses
to take a look as well.
Regards
Marcel
next prev parent reply other threads:[~2012-02-03 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 14:36 [RFCv2 00/10] Bluetooth: Change socket lock to l2cap_chan lock Emeltchenko Andrei
2012-02-03 14:36 ` [RFCv2 01/10] Bluetooth: Change chan_ready param from sk to chan Emeltchenko Andrei
2012-02-03 16:04 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 02/10] Bluetooth: Clean up l2cap_chan_add Emeltchenko Andrei
2012-02-03 16:04 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 03/10] Bluetooth: Remove unneeded sk variable Emeltchenko Andrei
2012-02-03 16:05 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 04/10] Bluetooth: Revert to mutexes from RCU list Emeltchenko Andrei
2012-02-03 16:06 ` Marcel Holtmann [this message]
2012-02-03 21:14 ` Ulisses Furquim
2012-02-06 10:44 ` Emeltchenko Andrei
2012-02-03 14:36 ` [RFCv2 05/10] Bluetooth: Add l2cap_chan_lock Emeltchenko Andrei
2012-02-03 16:07 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 06/10] Bluetooth: Add locked and unlocked state_change Emeltchenko Andrei
2012-02-03 16:08 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 07/10] Bluetooth: Add socket error function Emeltchenko Andrei
2012-02-03 16:09 ` Marcel Holtmann
2012-02-03 14:36 ` [RFCv2 08/10] Bluetooth: Change socket lock to chan lock Emeltchenko Andrei
2012-02-03 14:36 ` [RFCv2 09/10] Bluetooth: Use l2cap chan lock in socket connect Emeltchenko Andrei
2012-02-03 14:36 ` [RFCv2 10/10] Bluetooth: Remove socket lock check Emeltchenko Andrei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328285189.2062.39.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).