From: Patrick Ohly <patrick.ohly@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, Milan Crha <mcrha@redhat.com>,
ying.an.deng@intel.com, ulf.hofemeier@intel.com,
ning.w.wang@intel.com,
Tino Keitel <tino.keitel+syncevolution@tikei.de>,
Rohan Garg <rohan16garg@gmail.com>
Subject: Re: bluez 4.97: build failure when used in C++ apps
Date: Sun, 05 Feb 2012 11:56:03 +0100 [thread overview]
Message-ID: <1328439363.32199.20.camel@pohly-mobl1.fritz.box> (raw)
In-Reply-To: <1326708597.3360.133.camel@pohly-mobl1.fritz.box>
On Mon, 2012-01-16 at 11:09 +0100, Patrick Ohly wrote:
> On Mo, 2012-01-16 at 10:24 +0100, Marcel Holtmann wrote:
> > Also this topic
> > has been raised before and I need confirmation for a GCC guru to confirm
> > that this does exactly the same all all platforms.
>
> Now that you mentioned it I found the previous patch:
> http://article.gmane.org/gmane.linux.bluez.kernel/20276/match=invalid
> +conversion+void+bt_get_le64+anonymous+struct
>
> Note that my patch is different. It keeps the "struct
> __attribute__((packed))" magic and merely changes the (void *) typecast
> to something that works in C++ and C.
How do we move forward with this? More and more distros are picking up
the broken header file.
In MeeGo and Tizen we applied the patch that I had suggested.
Milan, do you know what Fedora is doing? Tino, what about Debian? Roran,
you had it in Ubuntu Precise Pangolin. Care to file a bug there, if
there isn't one already?
Would it be more acceptable for upstream to put the modified macros into
an ifdef so that they are really only used in C++, keeping the code for
C as it is now?
I'll send such a patch immediately.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2012-02-05 10:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 8:25 bluez 4.97: build failure when used in C++ apps Patrick Ohly
2012-01-16 8:48 ` Deng, Ying An
2012-01-16 9:24 ` Marcel Holtmann
2012-01-16 10:09 ` Patrick Ohly
2012-02-05 10:56 ` Patrick Ohly [this message]
2012-02-05 10:57 ` [PATCH] bluetooth.h: fix compile issue in C++ with ifdef Patrick Ohly
2012-02-05 11:07 ` Rohan Garg
2012-02-05 11:33 ` Patrick Ohly
2012-02-05 11:33 ` Rohan Garg
2012-02-05 12:23 ` Rohan Garg
2012-02-05 12:28 ` Rohan Garg
2012-02-05 10:59 ` bluez 4.97: build failure when used in C++ apps Rohan Garg
2012-02-05 12:02 ` Rohan Garg
2012-02-06 8:46 ` Milan Crha
2012-02-06 9:29 ` Patrick Ohly
2012-02-06 9:51 ` Milan Crha
2012-02-05 14:29 ` Tino Keitel
2012-02-05 14:50 ` Rohan Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328439363.32199.20.camel@pohly-mobl1.fritz.box \
--to=patrick.ohly@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcrha@redhat.com \
--cc=ning.w.wang@intel.com \
--cc=rohan16garg@gmail.com \
--cc=tino.keitel+syncevolution@tikei.de \
--cc=ulf.hofemeier@intel.com \
--cc=ying.an.deng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).