From: Marcel Holtmann <marcel@holtmann.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] l2cap_chan_connect() shouldn't be inlined
Date: Sun, 05 Feb 2012 11:12:10 -0800 [thread overview]
Message-ID: <1328469130.2062.77.camel@aeonflux> (raw)
In-Reply-To: <20120205062105.GZ23916@ZenIV.linux.org.uk>
Hi Al,
> For one thing, it's big. For another, the only caller is in a different
> file anyway...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 68f5891..124f7cf 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid);
> struct l2cap_chan *l2cap_chan_create(struct sock *sk);
> void l2cap_chan_close(struct l2cap_chan *chan, int reason);
> void l2cap_chan_destroy(struct l2cap_chan *chan);
> -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> bdaddr_t *dst);
I have no idea on how that happened, but you are fully correct this is
pointless.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-02-05 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 6:21 [PATCH] l2cap_chan_connect() shouldn't be inlined Al Viro
2012-02-05 19:12 ` Marcel Holtmann [this message]
2012-02-06 8:43 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328469130.2062.77.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).