From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Message-ID: <1328469130.2062.77.camel@aeonflux>
Subject: Re: [PATCH] l2cap_chan_connect() shouldn't be inlined
From: Marcel Holtmann <marcel@holtmann.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>
Date: Sun, 05 Feb 2012 11:12:10 -0800
In-Reply-To: <20120205062105.GZ23916@ZenIV.linux.org.uk>
References: <20120205062105.GZ23916@ZenIV.linux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Al,

> For one thing, it's big.  For another, the only caller is in a different
> file anyway...
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 68f5891..124f7cf 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan,  __u16 scid);
>  struct l2cap_chan *l2cap_chan_create(struct sock *sk);
>  void l2cap_chan_close(struct l2cap_chan *chan, int reason);
>  void l2cap_chan_destroy(struct l2cap_chan *chan);
> -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid,
>  								bdaddr_t *dst);

I have no idea on how that happened, but you are fully correct this is
pointless.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel