From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] Bluetooth: Fix not clearing ack timer when sending an i-frame
Date: Mon, 6 Feb 2012 16:38:53 +0200 [thread overview]
Message-ID: <1328539133-26410-1-git-send-email-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
When sending an i-frame the first time unacked_frames is incremented
which means we are waiting an ack and there is no need to send an ack
since the i-frame itself already serve that purpose.
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
net/bluetooth/l2cap_core.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 09cd860..e969677 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1448,8 +1448,10 @@ static int l2cap_ertm_send(struct l2cap_chan *chan)
chan->next_tx_seq = __next_seq(chan, chan->next_tx_seq);
- if (bt_cb(skb)->retries == 1)
+ if (bt_cb(skb)->retries == 1) {
chan->unacked_frames++;
+ __clear_ack_timer(chan);
+ }
chan->frames_sent++;
--
1.7.7.6
next reply other threads:[~2012-02-06 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 14:38 Luiz Augusto von Dentz [this message]
2012-02-06 17:27 ` [PATCH] Bluetooth: Fix not clearing ack timer when sending an i-frame Ulisses Furquim
2012-02-07 8:08 ` Szymon Janc
2012-02-07 10:21 ` Luiz Augusto von Dentz
2012-02-07 11:19 ` Ulisses Furquim
2012-02-07 11:21 ` Szymon Janc
2012-02-07 11:27 ` Ulisses Furquim
2012-02-07 12:02 ` Szymon Janc
2012-02-07 12:37 ` Ulisses Furquim
2012-02-07 13:28 ` Luiz Augusto von Dentz
2012-02-07 13:45 ` Ulisses Furquim
2012-02-07 13:59 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328539133-26410-1-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).