From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH obexd 12/13 v2] client: remove use of gobex in ftp module
Date: Tue, 7 Feb 2012 16:25:51 +0200 [thread overview]
Message-ID: <1328624752-26061-12-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1328624752-26061-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
gobex should not be use directly as it can interfere with ongoing
requests of the session.
---
client/ftp.c | 17 ++++++-----------
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/client/ftp.c b/client/ftp.c
index fdadf43..92fcaad 100644
--- a/client/ftp.c
+++ b/client/ftp.c
@@ -52,7 +52,7 @@ struct ftp_data {
DBusMessage *msg;
};
-static void async_cb(GObex *obex, GError *err, GObexPacket *rsp,
+static void async_cb(struct obc_session *session, GError *err,
gpointer user_data)
{
DBusMessage *reply, *msg = user_data;
@@ -72,7 +72,6 @@ static DBusMessage *change_folder(DBusConnection *connection,
{
struct ftp_data *ftp = user_data;
struct obc_session *session = ftp->session;
- GObex *obex = obc_session_get_obex(session);
const char *folder;
GError *err = NULL;
@@ -82,7 +81,7 @@ static DBusMessage *change_folder(DBusConnection *connection,
return g_dbus_create_error(message,
"org.openobex.Error.InvalidArguments", NULL);
- g_obex_setpath(obex, folder, async_cb, message, &err);
+ obc_session_setpath(session, folder, async_cb, message, &err);
if (err != NULL) {
DBusMessage *reply;
reply = g_dbus_create_error(message,
@@ -235,7 +234,6 @@ static DBusMessage *create_folder(DBusConnection *connection,
{
struct ftp_data *ftp = user_data;
struct obc_session *session = ftp->session;
- GObex *obex = obc_session_get_obex(session);
const char *folder;
GError *err = NULL;
@@ -245,7 +243,7 @@ static DBusMessage *create_folder(DBusConnection *connection,
return g_dbus_create_error(message,
"org.openobex.Error.InvalidArguments", NULL);
- g_obex_mkdir(obex, folder, async_cb, message, &err);
+ obc_session_mkdir(session, folder, async_cb, message, &err);
if (err != NULL) {
DBusMessage *reply;
reply = g_dbus_create_error(message,
@@ -340,7 +338,6 @@ static DBusMessage *copy_file(DBusConnection *connection,
{
struct ftp_data *ftp = user_data;
struct obc_session *session = ftp->session;
- GObex *obex = obc_session_get_obex(session);
const char *filename, *destname;
GError *err = NULL;
@@ -351,7 +348,7 @@ static DBusMessage *copy_file(DBusConnection *connection,
return g_dbus_create_error(message,
"org.openobex.Error.InvalidArguments", NULL);
- g_obex_copy(obex, filename, destname, async_cb, message, &err);
+ obc_session_copy(session, filename, destname, async_cb, message, &err);
if (err != NULL) {
DBusMessage *reply;
reply = g_dbus_create_error(message,
@@ -371,7 +368,6 @@ static DBusMessage *move_file(DBusConnection *connection,
{
struct ftp_data *ftp = user_data;
struct obc_session *session = ftp->session;
- GObex *obex = obc_session_get_obex(session);
const char *filename, *destname;
GError *err = NULL;
@@ -382,7 +378,7 @@ static DBusMessage *move_file(DBusConnection *connection,
return g_dbus_create_error(message,
"org.openobex.Error.InvalidArguments", NULL);
- g_obex_move(obex, filename, destname, async_cb, message, &err);
+ obc_session_move(session, filename, destname, async_cb, message, &err);
if (err != NULL) {
DBusMessage *reply;
reply = g_dbus_create_error(message,
@@ -402,7 +398,6 @@ static DBusMessage *delete(DBusConnection *connection,
{
struct ftp_data *ftp = user_data;
struct obc_session *session = ftp->session;
- GObex *obex = obc_session_get_obex(session);
const char *file;
GError *err = NULL;
@@ -412,7 +407,7 @@ static DBusMessage *delete(DBusConnection *connection,
return g_dbus_create_error(message,
"org.openobex.Error.InvalidArguments", NULL);
- g_obex_delete(obex, file, async_cb, message, &err);
+ obc_session_delete(session, file, async_cb, message, &err);
if (err != NULL) {
DBusMessage *reply;
reply = g_dbus_create_error(message,
--
1.7.7.6
next prev parent reply other threads:[~2012-02-07 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 14:25 [PATCH obexd 01/13 v2] client: fix not checking session_request return Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 02/13 v2] client: remove unused field from obc_session Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 03/13 v2] client: fix not queuing requests properly Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 04/13 v2] client: introduce obc_session_setpath Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 05/13 v2] client: introduce obc_session_mkdir Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 06/13 v2] client: introduce obc_session_copy Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 07/13 v2] client: introduce obc_session_move Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 08/13 v2] client: introduce obc_session_delete Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 09/13 v2] client: introduce obc_session_cancel Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 10/13 v2] client: remove use of gobex in pbap module Luiz Augusto von Dentz
2012-02-07 14:25 ` [PATCH obexd 11/13 v2] client: remove use of gobex in map module Luiz Augusto von Dentz
2012-02-07 14:25 ` Luiz Augusto von Dentz [this message]
2012-02-07 14:25 ` [PATCH obexd 13/13 v2] client: remove gobex dependency of session Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328624752-26061-12-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).