From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Ulisses Furquim <ulisses@profusion.mobi>,
kanak.gupta@stericsson.com
Subject: Re: [PATCH 1/2] Bluetooth: Fix possible missing I-Frame acknowledgement
Date: Thu, 09 Feb 2012 14:44:45 +0100 [thread overview]
Message-ID: <1328795085.28848.14.camel@aeonflux> (raw)
In-Reply-To: <1328625782-19624-1-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
> Make l2cap_ertm_send return number of pending I-Frames transmitted
> instead of all (pending + retransmitted) I-Frames transmitted.
>
> As only pending I-Frames are considered as acknowledgement, this could
> lead to situation when no ACK was sent in __l2cap_send_ack (if only
> already transmitted I-Frames were retransmitted).
>
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> net/bluetooth/l2cap_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-02-09 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 14:43 [PATCH 1/2] Bluetooth: Fix possible missing I-Frame acknowledgement Szymon Janc
2012-02-07 14:43 ` [PATCH 2/2] Bluetooth: Fix double acking I-Frames when sending pending I-Frames Szymon Janc
2012-02-07 15:26 ` Ulisses Furquim
2012-02-07 15:50 ` Luiz Augusto von Dentz
2012-02-09 13:45 ` Marcel Holtmann
2012-02-07 15:47 ` [PATCH 1/2] Bluetooth: Fix possible missing I-Frame acknowledgement Luiz Augusto von Dentz
2012-02-08 16:40 ` Gustavo Padovan
2012-02-09 13:44 ` Marcel Holtmann [this message]
2012-02-09 15:28 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328795085.28848.14.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=kanak.gupta@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=szymon.janc@tieto.com \
--cc=ulisses@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).