Re: [RFCv3 03/16] Bluetooth: Do not use sk lock in get_chan functions

[Marcel Holtmann <marcel@holtmann.org>]

Hi Andrei,

> When needed we take explicit lock.
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  net/bluetooth/l2cap_core.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index ae08944..dcf4792 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -105,9 +105,8 @@ static struct l2cap_chan *l2cap_get_chan_by_scid(struct l2cap_conn *conn, u16 ci
>  
>  	mutex_lock(&conn->chan_lock);
>  	c = __l2cap_get_chan_by_scid(conn, cid);
> -	if (c)
> -		lock_sock(c->sk);
>  	mutex_unlock(&conn->chan_lock);
> +
>  	return c;
>  }

so this is dangerous since now we are creating an imbalance with the
socket locks. Are we fixing that one later on?

Regards

Marcel