linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-bluetooth@vger.kernel.org
Cc: padovan@profusion.mobi, johan.hedberg@gmail.com,
	marcel@holtmann.org, David Herrmann <dh.herrmann@googlemail.com>
Subject: [RESEND PATCH] Bluetooth: btusb: Remove device lock on release
Date: Thu,  9 Feb 2012 21:58:31 +0100	[thread overview]
Message-ID: <1328821115-12514-2-git-send-email-dh.herrmann@googlemail.com> (raw)
In-Reply-To: <1328821115-12514-1-git-send-email-dh.herrmann@googlemail.com>

Recently we changed the way how we release driver-data. A driver is now
responsible of destroying the data so we no longer need the device lock
on deinitialization in btusb driver.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
---
Acked in: Message-ID: <1327960875.1955.183.camel@aeonflux>

 drivers/bluetooth/btusb.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index afcd281..12cb2f1 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1079,9 +1079,6 @@ static void btusb_disconnect(struct usb_interface *intf)
 		return;
 
 	hdev = data->hdev;
-
-	hci_dev_hold(hdev);
-
 	usb_set_intfdata(data->intf, NULL);
 
 	if (data->isoc)
@@ -1094,8 +1091,6 @@ static void btusb_disconnect(struct usb_interface *intf)
 	else if (data->isoc)
 		usb_driver_release_interface(&btusb_driver, data->isoc);
 
-	hci_dev_put(hdev);
-
 	hci_free_dev(hdev);
 	kfree(data);
 }
-- 
1.7.9

  reply	other threads:[~2012-02-09 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 20:58 [RESEND PATCH 1/4] Bluetooth: Introduce to_hci_dev() David Herrmann
2012-02-09 20:58 ` David Herrmann [this message]
2012-02-09 21:25   ` [RESEND PATCH] Bluetooth: btusb: Remove device lock on release Johan Hedberg
2012-02-10  5:12     ` Mohanan, Rajmohan
2012-02-09 20:58 ` [RESEND PATCH 2/4] Bluetooth: Remove hci_dev->driver_data David Herrmann
2012-02-09 20:58 ` [RESEND PATCH 3/4] Bluetooth: Introduce to_hci_conn David Herrmann
2012-02-09 20:58 ` [RESEND PATCH 4/4] Bluetooth: Use proper datatypes in release-callbacks David Herrmann
2012-02-09 21:24 ` [RESEND PATCH 1/4] Bluetooth: Introduce to_hci_dev() Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328821115-12514-2-git-send-email-dh.herrmann@googlemail.com \
    --to=dh.herrmann@googlemail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).