public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Mohanan, Rajmohan" <rajmohan.mohanan@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"padovan@profusion.mobi" <padovan@profusion.mobi>
Subject: RE: LMP transaction collision at Set encryption
Date: Mon, 13 Feb 2012 08:28:09 +0100	[thread overview]
Message-ID: <1329118089.28848.60.camel@aeonflux> (raw)
In-Reply-To: <E74476E55D15D942BA0FF3CDAD73606F041AE2@FMSMSX102.amr.corp.intel.com>

Hi Rajmohan,

<snip>

> I'm attaching patch for above two issues.
> 
> Please review it and  let me know the feedback.

please send one patch per email. That is what git format-patch and git
send-email are for.

The commit message needs to have a clear explanation of the issue and
how you are fixing it. Including hcidump log is a good idea as well in
these cases where you have some protocol issues.

Patches need to be signed-off-by and should not contain change-id (that
is Android Gerrit stuff).

Also patches need to be against the latest bluetooth-next tree.

Userspace patches should not contain signed-off-by and also no change-id
here as well.

The need to be against latest upstream and #if hacking is not allowed of
course.

Regards

Marcel



  reply	other threads:[~2012-02-13  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13  6:22 LMP transaction collision at Set encryption Mohanan, Rajmohan
2012-02-13  7:28 ` Marcel Holtmann [this message]
2012-02-13 10:16   ` Mohanan, Rajmohan
2012-02-13 10:41     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329118089.28848.60.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    --cc=rajmohan.mohanan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox