linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 0/4] GATT over LE reverse service discovery fixes
Date: Tue, 14 Feb 2012 12:06:00 -0400	[thread overview]
Message-ID: <1329235564-12471-1-git-send-email-anderson.lizardo@openbossa.org> (raw)

Hi,

This series fixes issues when doing reverse GATT service discovery over LE.

There is still one open issue: If BlueZ creates a device without bonding (i.e.
CreateDevice() D-Bus method), but the remote requests SMP pairing with
"Security Request", at the end of the pairing a reverse GATT service discovery
is issued, *regardless* of BlueZ being the initiator or not. BlueZ should only
do reverse discovery if it is the acceptor (see comments on the
device_bonding_complete() function on src/device.c).

To fix this, I think we need to have a more robust way to check whether we are
initiator or acceptor, instead of simply checking for an active bonding
request. Currently, if BlueZ receives keys from kernel over mgmt,
device_bonding_complete() is eventually called, and if there is no active
bonding, BlueZ assumes to be an acceptor.

In any case, with these patches we make sure this spurious service discovery
will not crash BlueZ or create leaks. It is also applicable for "normal"
reverse service discovery as well.

Best Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia (INdT)
Manaus - Brazil

             reply	other threads:[~2012-02-14 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 16:06 Anderson Lizardo [this message]
2012-02-14 16:06 ` [PATCH BlueZ 1/4] device: Fix NULL pointer dereference during GATT service discovery Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 2/4] device: Fix invalid memory read during GATT discovery Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 3/4] device: Fix invalid D-Bus calls during Reverse GATT Discovery Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 4/4] device: Fix memory leak during GATT service update Anderson Lizardo
2012-02-16 13:10 ` [PATCH BlueZ 0/4] GATT over LE reverse service discovery fixes Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329235564-12471-1-git-send-email-anderson.lizardo@openbossa.org \
    --to=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).