From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH BlueZ 4/4] device: Fix memory leak during GATT service update
Date: Tue, 14 Feb 2012 12:06:04 -0400 [thread overview]
Message-ID: <1329235564-12471-5-git-send-email-anderson.lizardo@openbossa.org> (raw)
In-Reply-To: <1329235564-12471-1-git-send-email-anderson.lizardo@openbossa.org>
GATT service updates are not supported yet. This patch avoids a memory
leak and GATT service storage corruption due to trying to register GATT
services twice.
After adding support for Services Changed characteristic notification
(which is mandatory for GATT clients), this check can be removed.
---
src/device.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/device.c b/src/device.c
index b410a63..dfc8e59 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1982,6 +1982,14 @@ int device_browse_primary(struct btd_device *device, DBusConnection *conn,
if (device->browse)
return -EBUSY;
+ /* FIXME: GATT service updates (implemented in update_services() for
+ * SDP) are not supported yet. It will be supported once client side
+ * "Services Changed" characteristic handling is implemented. */
+ if (device->primaries) {
+ error("Could not update GATT services");
+ return -ENOSYS;
+ }
+
req = g_new0(struct browse_req, 1);
req->device = btd_device_ref(device);
adapter_get_address(adapter, &src);
--
1.7.5.4
next prev parent reply other threads:[~2012-02-14 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 16:06 [PATCH BlueZ 0/4] GATT over LE reverse service discovery fixes Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 1/4] device: Fix NULL pointer dereference during GATT service discovery Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 2/4] device: Fix invalid memory read during GATT discovery Anderson Lizardo
2012-02-14 16:06 ` [PATCH BlueZ 3/4] device: Fix invalid D-Bus calls during Reverse GATT Discovery Anderson Lizardo
2012-02-14 16:06 ` Anderson Lizardo [this message]
2012-02-16 13:10 ` [PATCH BlueZ 0/4] GATT over LE reverse service discovery fixes Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329235564-12471-5-git-send-email-anderson.lizardo@openbossa.org \
--to=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).