linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH BlueZ 2/3] thermometer: Fix handling of missing Temperature Type
Date: Tue, 14 Feb 2012 13:52:24 -0400	[thread overview]
Message-ID: <1329241945-32414-2-git-send-email-anderson.lizardo@openbossa.org> (raw)
In-Reply-To: <1329241945-32414-1-git-send-email-anderson.lizardo@openbossa.org>

According to HTS 1.0, it is not mandatory to have Temperature Type
information (the Characteristic and the indication field are both
unconditionally optional).

Given there is no default value specified on the spec, we assume the
thermometer is for general use, and set the type to "Body".
---
 thermometer/thermometer.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/thermometer/thermometer.c b/thermometer/thermometer.c
index 9bf9881..7906d84 100644
--- a/thermometer/thermometer.c
+++ b/thermometer/thermometer.c
@@ -1086,13 +1086,8 @@ static void proc_measurement(struct thermometer *t, const uint8_t *pdu,
 		type = temptype2str(pdu[index]);
 	} else if (t->has_type)
 		type = temptype2str(t->type);
-	else {
-		DBG("Can't get temperature type");
-		return;
-	}
-
-	if (type == NULL)
-		return;
+	else
+		type = "Body";
 
 	m.type = g_strdup(type);
 	m.value = final ? "Final" : "Intermediate";
-- 
1.7.5.4


  reply	other threads:[~2012-02-14 17:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 17:52 [PATCH BlueZ 1/3] thermometer: Fix device driver probe Anderson Lizardo
2012-02-14 17:52 ` Anderson Lizardo [this message]
2012-02-15  8:50   ` [PATCH BlueZ 2/3] thermometer: Fix handling of missing Temperature Type Santiago Carot
2012-02-15 10:41     ` Anderson Lizardo
2012-02-15 11:06       ` Santiago Carot
2012-02-15 11:53         ` Anderson Lizardo
2012-02-15 12:49         ` Anderson Lizardo
2012-02-14 17:52 ` [PATCH BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection Anderson Lizardo
2012-02-15  9:03   ` Santiago Carot
2012-02-15 10:44     ` Anderson Lizardo
2012-02-15 12:38 ` [PATCH v2 BlueZ 1/3] thermometer: Fix device driver probe Anderson Lizardo
2012-02-15 12:38   ` [PATCH v2 BlueZ 2/3] thermometer: Fix handling of missing Temperature Type Anderson Lizardo
2012-02-15 12:38   ` [PATCH v2 BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection Anderson Lizardo
2012-02-16 13:13   ` [PATCH v2 BlueZ 1/3] thermometer: Fix device driver probe Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329241945-32414-2-git-send-email-anderson.lizardo@openbossa.org \
    --to=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).