From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 1/4] Bluetooth: Prepare start_discovery
Date: Fri, 17 Feb 2012 09:44:46 +0100 [thread overview]
Message-ID: <1329468286.28848.137.camel@aeonflux> (raw)
In-Reply-To: <CACJA=fXw2Dx2bWE-=GKhmJKBTKK3NvNWjTqATSLvi2xgFi0m1A@mail.gmail.com>
Hi Andre,
> > On Thu, Feb 16, 2012, Andre Guedes wrote:
> >> +#define DISCOV_TYPE_BREDR (BIT(0))
> >> +#define DISCOV_TYPE_LE (BIT(1) | BIT(2))
> >> +#define DISCOV_TYPE_INTERLEAVED (BIT(0) | BIT(1) | BIT(2))
> >
> > Defining these like this looks a bit (no pun intended) odd. The previous
> > code was at least using the mgmt defs instead of magic numbers (which is
> > how these values have been originally chosen too).
>
> Do you think this would be better?
>
> +#define DISCOV_TYPE_BREDR (BIT(MGMT_ADDR_BREDR))
> +#define DISCOV_TYPE_LE (BIT(MGMT_ADDR_LE_PUBLIC) |
> BIT(MGMT_ADDR_LE_RANDOM))
> +#define DISCOV_TYPE_INTERLEAVED (BIT(MGMT_ADDR_BREDR) |
> BIT(MGMT_ADDR_LE_PUBLIC) | \
> +
> BIT(MGMT_ADDR_LE_RANDOM))
even while I already acked the previous patch, this is a bit better.
Regards
Marcel
next prev parent reply other threads:[~2012-02-17 8:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 21:50 [RFC 0/4] MGMT Start Discovery interleaved support Andre Guedes
2012-02-16 21:50 ` [RFC 1/4] Bluetooth: Prepare start_discovery Andre Guedes
2012-02-16 22:15 ` Johan Hedberg
2012-02-16 23:30 ` Andre Guedes
2012-02-17 8:44 ` Marcel Holtmann [this message]
2012-02-17 8:43 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 2/4] Bluetooth: Track discovery type Andre Guedes
2012-02-17 8:50 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 3/4] Bluetooth: Merge INQUIRY and LE_SCAN discovery states Andre Guedes
2012-02-17 8:50 ` Marcel Holtmann
2012-02-16 21:50 ` [RFC 4/4] Bluetooth: Interleaved discovery support Andre Guedes
2012-02-16 22:12 ` Johan Hedberg
2012-02-16 23:30 ` Andre Guedes
2012-02-17 8:48 ` Marcel Holtmann
2012-02-17 14:52 ` Johan Hedberg
2012-02-17 15:00 ` Johan Hedberg
2012-02-17 15:23 ` Ulisses Furquim
2012-02-17 15:25 ` Ulisses Furquim
2012-02-17 16:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329468286.28848.137.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).