From: Marcel Holtmann <marcel@holtmann.org>
To: "Mohanan, Rajmohan" <rajmohan.mohanan@intel.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH] LMP transaction collision at Set encryption
Date: Fri, 17 Feb 2012 09:53:05 +0100 [thread overview]
Message-ID: <1329468785.28848.143.camel@aeonflux> (raw)
In-Reply-To: <E74476E55D15D942BA0FF3CDAD73606F043646@FMSMSX102.amr.corp.intel.com>
Hi Rajmohan,
please refrain from top-posting on the mailing list. Please do inline
quoting.
> In Lmp transaction collision happens at set encryption request ,
> if encrypt change event with status code " LMP transaction collision "comes and will start the disconnection procedure.
> If encryption change event with success(Master initiated) comes with in 10 millisecond, then conn->refcount will go to a negative value(because hci_conn_put is calling and it will decrement the reference count which was zero already in the previous error response). At this time disconnection won't happen but the reference count value went to negative which will make the timer operations in a bad state. I have faced this issue two times.
>
> If I'm misunderstood please correct me.
>
> So the patch solves this issue also.
Please reply to patches properly. I have not idea what the above
statement has to do with my review.
Regards
Marcel
prev parent reply other threads:[~2012-02-17 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <LMP Transaction collision>
2012-02-14 8:57 ` [PATCH] LMP transaction collision at Set encryption rajmohan.mohanan
2012-02-14 11:33 ` Luiz Augusto von Dentz
2012-02-14 13:16 ` Mohanan, Rajmohan
2012-02-15 12:29 ` Marcel Holtmann
2012-02-17 4:41 ` Mohanan, Rajmohan
2012-02-17 8:53 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329468785.28848.143.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=rajmohan.mohanan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox