linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv5 09/16] Bluetooth: Use chan lock in timers
Date: Fri, 17 Feb 2012 15:44:05 +0200	[thread overview]
Message-ID: <1329486252-25252-10-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1329486252-25252-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Change locking in delayed works to chan lock instead of sk lock.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 net/bluetooth/l2cap_core.c |   26 ++++++++++++++------------
 1 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index db1640c..727a1dd 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -238,13 +238,12 @@ static void l2cap_chan_timeout(struct work_struct *work)
 	struct l2cap_chan *chan = container_of(work, struct l2cap_chan,
 							chan_timer.work);
 	struct l2cap_conn *conn = chan->conn;
-	struct sock *sk = chan->sk;
 	int reason;
 
 	BT_DBG("chan %p state %s", chan, state_to_string(chan->state));
 
 	mutex_lock(&conn->chan_lock);
-	lock_sock(sk);
+	l2cap_chan_lock(chan);
 
 	if (chan->state == BT_CONNECTED || chan->state == BT_CONFIG)
 		reason = ECONNREFUSED;
@@ -256,7 +255,7 @@ static void l2cap_chan_timeout(struct work_struct *work)
 
 	l2cap_chan_close(chan, reason);
 
-	release_sock(sk);
+	l2cap_chan_unlock(chan);
 
 	chan->ops->close(chan->data);
 	mutex_unlock(&conn->chan_lock);
@@ -1277,14 +1276,14 @@ static void l2cap_monitor_timeout(struct work_struct *work)
 {
 	struct l2cap_chan *chan = container_of(work, struct l2cap_chan,
 							monitor_timer.work);
-	struct sock *sk = chan->sk;
 
 	BT_DBG("chan %p", chan);
 
-	lock_sock(sk);
+	l2cap_chan_lock(chan);
+
 	if (chan->retry_count >= chan->remote_max_tx) {
 		l2cap_send_disconn_req(chan->conn, chan, ECONNABORTED);
-		release_sock(sk);
+		l2cap_chan_unlock(chan);
 		return;
 	}
 
@@ -1292,25 +1291,26 @@ static void l2cap_monitor_timeout(struct work_struct *work)
 	__set_monitor_timer(chan);
 
 	l2cap_send_rr_or_rnr(chan, L2CAP_CTRL_POLL);
-	release_sock(sk);
+	l2cap_chan_unlock(chan);
 }
 
 static void l2cap_retrans_timeout(struct work_struct *work)
 {
 	struct l2cap_chan *chan = container_of(work, struct l2cap_chan,
 							retrans_timer.work);
-	struct sock *sk = chan->sk;
 
 	BT_DBG("chan %p", chan);
 
-	lock_sock(sk);
+	l2cap_chan_lock(chan);
+
 	chan->retry_count = 1;
 	__set_monitor_timer(chan);
 
 	set_bit(CONN_WAIT_F, &chan->conn_state);
 
 	l2cap_send_rr_or_rnr(chan, L2CAP_CTRL_POLL);
-	release_sock(sk);
+
+	l2cap_chan_unlock(chan);
 }
 
 static void l2cap_drop_acked_frames(struct l2cap_chan *chan)
@@ -2001,9 +2001,11 @@ static void l2cap_ack_timeout(struct work_struct *work)
 
 	BT_DBG("chan %p", chan);
 
-	lock_sock(chan->sk);
+	l2cap_chan_lock(chan);
+
 	__l2cap_send_ack(chan);
-	release_sock(chan->sk);
+
+	l2cap_chan_unlock(chan);
 
 	l2cap_chan_put(chan);
 }
-- 
1.7.9


  parent reply	other threads:[~2012-02-17 13:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17 13:43 [RFCv5 00/16] Bluetooth: Change socket lock to l2cap_chan lock Emeltchenko Andrei
2012-02-17 13:43 ` [RFCv5 01/16] Bluetooth: trivial: Fix long line Emeltchenko Andrei
2012-02-17 13:43 ` [RFCv5 02/16] Bluetooth: Revert to mutexes from RCU list Emeltchenko Andrei
2012-02-17 21:22   ` Ulisses Furquim
2012-02-19 19:49     ` Andrei Emeltchenko
2012-02-20 11:55       ` Ulisses Furquim
2012-02-20 12:17         ` Andrei Emeltchenko
2012-02-17 13:43 ` [RFCv5 03/16] Bluetooth: Lock chan list when deleting chan Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 04/16] Bluetooth: Do not use sk lock in get_chan functions Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 05/16] Bluetooth: Add l2cap_chan_lock Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 06/16] Bluetooth: Add locked and unlocked state_change Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 07/16] Bluetooth: Add socket error function Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 08/16] Bluetooth: Add unlocked __l2cap_chan_add function Emeltchenko Andrei
2012-02-17 13:44 ` Emeltchenko Andrei [this message]
2012-02-17 13:44 ` [RFCv5 10/16] Bluetooth: Use chan lock in L2CAP sig commands Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 11/16] Bluetooth: Use chan lock in L2CAP conn start Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 12/16] Bluetooth: Use chan lock in receiving data Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 13/16] Bluetooth: Change locking logic for conn/chan ready Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 14/16] Bluetooth: Change locking logic in security_cfm Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 15/16] Bluetooth: Use l2cap chan lock in socket connect Emeltchenko Andrei
2012-02-17 13:44 ` [RFCv5 16/16] Bluetooth: Remove socket lock check Emeltchenko Andrei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329486252-25252-10-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).