linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH obexd 4/8] gobex: Use ENOSYS to correspond to OBEX not implemented
Date: Sat, 18 Feb 2012 17:18:59 +0200	[thread overview]
Message-ID: <1329578343-31663-4-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1329578343-31663-1-git-send-email-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

ENOSYS correspond to function not implemented which is exactly what the
OBEX error code means.

Also since EINVAL means invalid argument that now map to OBEX bad request
---
 gobex/gobex.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gobex/gobex.c b/gobex/gobex.c
index 0ced782..0665749 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -1482,11 +1482,12 @@ guint8 g_obex_errno_to_rsp(int err)
 		return G_OBEX_RSP_FORBIDDEN;
 	case -ENOENT:
 		return G_OBEX_RSP_NOT_FOUND;
+	case -EINVAL:
 	case -EBADR:
 		return G_OBEX_RSP_BAD_REQUEST;
 	case -EFAULT:
 		return G_OBEX_RSP_SERVICE_UNAVAILABLE;
-	case -EINVAL:
+	case -ENOSYS:
 		return G_OBEX_RSP_NOT_IMPLEMENTED;
 	case -ENOTEMPTY:
 	case -EEXIST:
-- 
1.7.7.6


  parent reply	other threads:[~2012-02-18 15:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 15:18 [PATCH obexd 1/8] core: Fix queueing packet containing error while suspended Luiz Augusto von Dentz
2012-02-18 15:18 ` [PATCH obexd 2/8] gobex: Translate posix error code to proper OBEX response opcode Luiz Augusto von Dentz
2012-02-18 15:18 ` [PATCH obexd 3/8] core: Make use of g_obex_errno_to_rsp to translate posix errors Luiz Augusto von Dentz
2012-02-18 15:18 ` Luiz Augusto von Dentz [this message]
2012-02-18 15:19 ` [PATCH obexd 5/8] core: Use ENOSYS to indicate not implemented function Luiz Augusto von Dentz
2012-02-18 15:19 ` [PATCH obexd 6/8] ftp: " Luiz Augusto von Dentz
2012-02-18 15:19 ` [PATCH obexd 7/8] core: " Luiz Augusto von Dentz
2012-02-18 15:19 ` [PATCH obexd 8/8] map: " Luiz Augusto von Dentz
2012-02-19 22:19 ` [PATCH obexd 1/8] core: Fix queueing packet containing error while suspended Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329578343-31663-4-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).