From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 4/6] Bluetooth: mgmt: Fix Start Discovery return parameters
Date: Sun, 19 Feb 2012 13:54:27 +0200 [thread overview]
Message-ID: <1329652469-28973-4-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1329652469-28973-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
The same address type that was passed to the Start Discovery command
should also be returned in the response message.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/mgmt.c | 15 +++++++++++++--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 79255f5..258adf4 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -3325,6 +3325,7 @@ int mgmt_remote_name(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
int mgmt_start_discovery_failed(struct hci_dev *hdev, u8 status)
{
struct pending_cmd *cmd;
+ u8 type;
int err;
hci_discovery_set_state(hdev, DISCOVERY_STOPPED);
@@ -3333,7 +3334,10 @@ int mgmt_start_discovery_failed(struct hci_dev *hdev, u8 status)
if (!cmd)
return -ENOENT;
- err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status));
+ type = hdev->discovery.type;
+
+ err = cmd_complete(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status),
+ &type, sizeof(type));
mgmt_pending_remove(cmd);
return err;
@@ -3366,7 +3370,14 @@ int mgmt_discovering(struct hci_dev *hdev, u8 discovering)
cmd = mgmt_pending_find(MGMT_OP_STOP_DISCOVERY, hdev);
if (cmd != NULL) {
- cmd_complete(cmd->sk, hdev->id, cmd->opcode, 0, NULL, 0);
+ u8 type = hdev->discovery.type;
+
+ if (discovering)
+ cmd_complete(cmd->sk, hdev->id, cmd->opcode, 0,
+ &type, sizeof(type));
+ else
+ cmd_complete(cmd->sk, hdev->id, cmd->opcode, 0,
+ NULL, 0);
mgmt_pending_remove(cmd);
}
--
1.7.9
next prev parent reply other threads:[~2012-02-19 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 11:54 [PATCH 1/6] Bluetooth: mgmt: Change ordering of cmd_status paramters johan.hedberg
2012-02-19 11:54 ` [PATCH 2/6] Bluetooth: mgmt: Move status parameters into the cmd_complete header johan.hedberg
2012-02-19 11:57 ` Marcel Holtmann
2012-02-19 11:54 ` [PATCH 3/6] Bluetooth: mgmt: Fix Pair Device response status values johan.hedberg
2012-02-19 11:58 ` Marcel Holtmann
2012-02-19 11:54 ` johan.hedberg [this message]
2012-02-19 11:58 ` [PATCH 4/6] Bluetooth: mgmt: Fix Start Discovery return parameters Marcel Holtmann
2012-02-19 11:54 ` [PATCH 5/6] Bluetooth: mgmt: Fix (Un)Block Device " johan.hedberg
2012-02-19 11:59 ` Marcel Holtmann
2012-02-19 11:54 ` [PATCH 6/6] Bluetooth: mgmt: Fix OOB command response parameters johan.hedberg
2012-02-19 12:00 ` Marcel Holtmann
2012-02-19 11:56 ` [PATCH 1/6] Bluetooth: mgmt: Change ordering of cmd_status paramters Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329652469-28973-4-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).