linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH obexd v2 2/8] client: fix obc_session_get_buffer
Date: Tue, 21 Feb 2012 14:57:06 +0100	[thread overview]
Message-ID: <1329832632-3681-3-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1329832632-3681-1-git-send-email-mikel.astiz.oss@gmail.com>

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

Size 0 should be reported if no transfer exists. Some existing code
relies on this behavior.
---
 client/session.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/client/session.c b/client/session.c
index 85f466a..e113d1f 100644
--- a/client/session.c
+++ b/client/session.c
@@ -1128,8 +1128,12 @@ const char *obc_session_get_buffer(struct obc_session *session, size_t *size)
 	const char *buf;
 
 	transfer = obc_session_get_transfer(session);
-	if (transfer == NULL)
+	if (transfer == NULL) {
+		if (size != NULL)
+			*size = 0;
+
 		return NULL;
+	}
 
 	buf = obc_transfer_get_buffer(transfer, size);
 
-- 
1.7.6.5


  parent reply	other threads:[~2012-02-21 13:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 13:57 [PATCH obexd v2 0/8] Transfer cancelation Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 1/8] gobex: fix callback remove when canceling transfer Mikel Astiz
2012-02-21 13:57 ` Mikel Astiz [this message]
2012-02-21 13:57 ` [PATCH obexd v2 3/8] client: fix cancel when no agent present Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 4/8] client: process transfer queue only if none active Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 5/8] client: terminate queued transfers properly Mikel Astiz
2012-02-26 17:23   ` Johan Hedberg
2012-02-21 13:57 ` [PATCH obexd v2 6/8] client: expose obc_transfer_set_callback Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 7/8] client: fix canceling queued transfers Mikel Astiz
2012-02-22 11:41   ` Jaganath
2012-02-22 11:59     ` Jaganath
2012-02-22 12:15       ` Luiz Augusto von Dentz
2012-02-22 12:24         ` Jaganath
2012-02-22 12:39           ` Luiz Augusto von Dentz
2012-02-26 17:26   ` Johan Hedberg
2012-02-21 13:57 ` [PATCH obexd v2 8/8] client: make sure callback does not match size Mikel Astiz
2012-02-24  9:33 ` [PATCH obexd v2 0/8] Transfer cancelation Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329832632-3681-3-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).