From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH obexd v2 3/8] client: fix cancel when no agent present
Date: Tue, 21 Feb 2012 14:57:07 +0100 [thread overview]
Message-ID: <1329832632-3681-4-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1329832632-3681-1-git-send-email-mikel.astiz.oss@gmail.com>
From: Mikel Astiz <mikel.astiz@bmw-carit.de>
The authorization check should consider the scenario of no agent being
assigned to the transfer.
---
client/transfer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/transfer.c b/client/transfer.c
index 157811d..4054799 100644
--- a/client/transfer.c
+++ b/client/transfer.c
@@ -168,7 +168,7 @@ static DBusMessage *obc_transfer_cancel(DBusConnection *connection,
DBusMessage *reply;
sender = dbus_message_get_sender(message);
- if (g_str_equal(transfer->agent, sender) == FALSE)
+ if (g_strcmp0(transfer->agent, sender) != 0)
return g_dbus_create_error(message,
"org.openobex.Error.NotAuthorized",
"Not Authorized");
--
1.7.6.5
next prev parent reply other threads:[~2012-02-21 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 13:57 [PATCH obexd v2 0/8] Transfer cancelation Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 1/8] gobex: fix callback remove when canceling transfer Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 2/8] client: fix obc_session_get_buffer Mikel Astiz
2012-02-21 13:57 ` Mikel Astiz [this message]
2012-02-21 13:57 ` [PATCH obexd v2 4/8] client: process transfer queue only if none active Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 5/8] client: terminate queued transfers properly Mikel Astiz
2012-02-26 17:23 ` Johan Hedberg
2012-02-21 13:57 ` [PATCH obexd v2 6/8] client: expose obc_transfer_set_callback Mikel Astiz
2012-02-21 13:57 ` [PATCH obexd v2 7/8] client: fix canceling queued transfers Mikel Astiz
2012-02-22 11:41 ` Jaganath
2012-02-22 11:59 ` Jaganath
2012-02-22 12:15 ` Luiz Augusto von Dentz
2012-02-22 12:24 ` Jaganath
2012-02-22 12:39 ` Luiz Augusto von Dentz
2012-02-26 17:26 ` Johan Hedberg
2012-02-21 13:57 ` [PATCH obexd v2 8/8] client: make sure callback does not match size Mikel Astiz
2012-02-24 9:33 ` [PATCH obexd v2 0/8] Transfer cancelation Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329832632-3681-4-git-send-email-mikel.astiz.oss@gmail.com \
--to=mikel.astiz.oss@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).