From: Marcel Holtmann <marcel@holtmann.org>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Remove HCI_PI_MGMT_INIT flag for sockets
Date: Fri, 02 Mar 2012 15:25:28 -0800 [thread overview]
Message-ID: <1330730728.3392.129.camel@aeonflux> (raw)
In-Reply-To: <1330727590-27120-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
> This flag is of no use right now and is in fact harmful in that it
> prevents the HCI_MGMT flag to be set for any controllers that may need
> it after the first one that bluetoothd takes into use (the flag is
> cleared for the first controller so any subsequent ones through the same
> bluetoothd mgmt socket never get the HCI_MGMT flag set).
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> include/net/bluetooth/hci_core.h | 4 ----
> net/bluetooth/hci_sock.c | 1 -
> net/bluetooth/mgmt.c | 18 ++++++++----------
> 3 files changed, 8 insertions(+), 15 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
prev parent reply other threads:[~2012-03-02 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 22:33 [PATCH 1/2] Bluetooth: Remove HCI_PI_MGMT_INIT flag for sockets johan.hedberg
2012-03-02 22:33 ` [PATCH 2/2] Bluetooth: mgmt: Fix updating local name when powering on johan.hedberg
2012-03-02 23:26 ` Marcel Holtmann
2012-03-02 23:25 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330730728.3392.129.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).