linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Hansen <x@jeffhansen.com>
To: linux-bluetooth@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>, Jeff Hansen <x@jeffhansen.com>
Subject: [PATCH] [input] Set up uinput device again, if it was previously closed.
Date: Sun,  4 Mar 2012 20:44:19 -0700	[thread overview]
Message-ID: <1330919059-5493-1-git-send-email-x@jeffhansen.com> (raw)

If you connect a PS3 controller to bluetoothd as an input device, then
take the batteries out of a PS3 controller, then put them back in and
push a few buttons, it will eventually cause an error which causes the
uinput socket to be closed. It will then re-connect to bluetoothd, but
the uinput socket fd will be -1, so it needs to be set up again after
the re-connect.

Signed-off-by: Jeff Hansen <x@jeffhansen.com>
---
 input/fakehid.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/input/fakehid.c b/input/fakehid.c
index eebca05..a83f8c3 100644
--- a/input/fakehid.c
+++ b/input/fakehid.c
@@ -393,12 +393,15 @@ struct fake_input *fake_hid_connadd(struct fake_input *fake,
 
 	/* New device? Add it to the list of known devices,
 	 * and create the uinput necessary */
-	if (old == NULL) {
+	if (old == NULL || old->uinput == -1) {
 		if (fake_hid->setup_uinput(fake, fake_hid)) {
 			error("Error setting up uinput");
 			g_free(fake);
 			return NULL;
 		}
+	}
+
+	if (old == NULL) {
 		fake_hid->devices = g_list_append(fake_hid->devices, fake);
 	}
 
-- 
1.7.3.4

             reply	other threads:[~2012-03-05  3:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05  3:44 Jeff Hansen [this message]
2012-03-05  5:11 ` [PATCH] [input] Set up uinput device again, if it was previously closed Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330919059-5493-1-git-send-email-x@jeffhansen.com \
    --to=x@jeffhansen.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).