From: Ido Yariv <ido@wizery.com>
To: linux-bluetooth@vger.kernel.org
Cc: Ido Yariv <ido@wizery.com>
Subject: [PATCH] Storage: Fix a buffer overflow in write_link_key
Date: Mon, 5 Mar 2012 20:12:31 +0200 [thread overview]
Message-ID: <1330971151-11075-1-git-send-email-ido@wizery.com> (raw)
The temporary string allocated on the stack is not large enough in worst
case. To be on the safe side, increase it to 64 bytes.
Signed-off-by: Ido Yariv <ido@wizery.com>
---
src/storage.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/storage.c b/src/storage.c
index a65cee4..7e7f081 100644
--- a/src/storage.c
+++ b/src/storage.c
@@ -533,7 +533,7 @@ int write_lastused_info(bdaddr_t *local, bdaddr_t *peer, struct tm *tm)
int write_link_key(bdaddr_t *local, bdaddr_t *peer, unsigned char *key, uint8_t type, int length)
{
- char filename[PATH_MAX + 1], addr[18], str[38];
+ char filename[PATH_MAX + 1], addr[18], str[64];
int i;
memset(str, 0, sizeof(str));
--
1.7.7.6
next reply other threads:[~2012-03-05 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 18:12 Ido Yariv [this message]
2012-03-05 20:01 ` [PATCH] Storage: Fix a buffer overflow in write_link_key Johan Hedberg
2012-03-06 1:34 ` Ido Yariv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330971151-11075-1-git-send-email-ido@wizery.com \
--to=ido@wizery.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).