[PATCH obexd] build: Fix libbluetooth dependency

[PATCH obexd] build: Fix libbluetooth dependency

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Building with libbluetooth prior to 4.99 cause an error:

btio/btio.c: In function 'get_key_size':
btio/btio.c:522:14: error: 'struct bt_security' has no member named 'key_size

Thanks to Bastien Nocera for reporting it.
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 10c561b..f54cce7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -89,8 +89,8 @@ AC_CHECK_LIB(dbus-1, dbus_connection_can_send_type, dummy=yes,
 AC_SUBST(DBUS_CFLAGS)
 AC_SUBST(DBUS_LIBS)
 
-PKG_CHECK_MODULES(BLUEZ, bluez, dummy=yes,
-				AC_MSG_ERROR(libbluetooth is required))
+PKG_CHECK_MODULES(BLUEZ, bluez >= 4.99, dummy=yes,
+				AC_MSG_ERROR(libbluetooth 4.99 or latter is required))
 AC_SUBST(BLUEZ_CFLAGS)
 AC_SUBST(BLUEZ_LIBS)
 
-- 
1.7.7.6

Re: [PATCH obexd] build: Fix libbluetooth dependency

[Marcel Holtmann]

Hi Luiz,

> Building with libbluetooth prior to 4.99 cause an error:
> 
> btio/btio.c: In function 'get_key_size':
> btio/btio.c:522:14: error: 'struct bt_security' has no member named 'key_size
> 
> Thanks to Bastien Nocera for reporting it.
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

I rather not have this patch included since it makes things complicated
for people to build this. Copying over just the header is good enough to
fix this.

Regards

Marcel

Re: [PATCH obexd] build: Fix libbluetooth dependency

[Luiz Augusto von Dentz]

Hi Marcel,

On Wed, Mar 7, 2012 at 9:16 PM, Marcel Holtmann <marcel@holtmann.org> wrote=
:
> Hi Luiz,
>
>> Building with libbluetooth prior to 4.99 cause an error:
>>
>> btio/btio.c: In function 'get_key_size':
>> btio/btio.c:522:14: error: 'struct bt_security' has no member named 'key=
_size
>>
>> Thanks to Bastien Nocera for reporting it.
>> ---
>> =A0configure.ac | =A0 =A04 ++--
>> =A01 files changed, 2 insertions(+), 2 deletions(-)
>
> I rather not have this patch included since it makes things complicated
> for people to build this. Copying over just the header is good enough to
> fix this.

I would agree if we do static linking the whole libbluetooth, but just
a header IMO that is asking for trouble e.g. it could still cause
linking problems due to missing implementation or even crashes.

Maybe we should think more seriously about moving obexd inside BlueZ.


--=20
Luiz Augusto von Dentz