linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH obexd v2 0/4] client: parameter naming convention
Date: Wed,  7 Mar 2012 15:50:25 +0100	[thread overview]
Message-ID: <1331131829-28509-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

These patches review the naming convention in transfer.h and session.h, in order to avoid misleading use of the terms "name", "filename" and "targetname".

This second proposal splits the first patch into two patches, and avoids a bug that would have been introduced: the reply of the agent needs to be handled with care, since depending on the operation type (put or get) the reply of the agent should overwrite one field or the other.

Mikel Astiz (4):
  client: add obc_transfer_set_filename
  client: fix naming convention in transfer api
  client: refactor naming convention in session api
  client: simplify obc_session_pull

 client/session.c  |   55 ++++++++++++++++++----------------------------------
 client/session.h  |   12 +++++-----
 client/transfer.c |   14 +++++++++---
 client/transfer.h |    2 +
 4 files changed, 37 insertions(+), 46 deletions(-)

-- 
1.7.6.5


             reply	other threads:[~2012-03-07 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 14:50 Mikel Astiz [this message]
2012-03-07 14:50 ` [PATCH obexd v2 1/4] client: add obc_transfer_set_filename Mikel Astiz
2012-03-07 14:50 ` [PATCH obexd v2 2/4] client: fix naming convention in transfer api Mikel Astiz
2012-03-07 14:50 ` [PATCH obexd v2 3/4] client: refactor naming convention in session api Mikel Astiz
2012-03-07 14:50 ` [PATCH obexd v2 4/4] client: simplify obc_session_pull Mikel Astiz
2012-03-08 10:28 ` [PATCH obexd v2 0/4] client: parameter naming convention Luiz Augusto von Dentz
2012-03-09  0:01 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331131829-28509-1-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).