From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix extra conversion to __le32
Date: Fri, 09 Mar 2012 09:06:36 -0800 [thread overview]
Message-ID: <1331312796.14217.14.camel@aeonflux> (raw)
In-Reply-To: <1331290850-30092-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Value to be converted is already in __le32 format.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 7fcff88..97b5b6c 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -3107,7 +3107,7 @@ int mgmt_user_confirm_request(struct hci_dev *hdev, bdaddr_t *bdaddr,
> bacpy(&ev.addr.bdaddr, bdaddr);
> ev.addr.type = link_to_mgmt(link_type, addr_type);
> ev.confirm_hint = confirm_hint;
> - put_unaligned_le32(value, &ev.value);
> + ev.value = value;
actually we do not need put_unaligned_le32 anyway here since the struct
itself is already __packed. So you might wanna go through the code and
fix these up as well.
Regards
Marcel
prev parent reply other threads:[~2012-03-09 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 11:00 [PATCH] Bluetooth: Fix extra conversion to __le32 Andrei Emeltchenko
2012-03-09 12:41 ` Gustavo Padovan
2012-03-09 17:06 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331312796.14217.14.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).