From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: trivial: Fix endian conversion mode
Date: Fri, 09 Mar 2012 09:10:58 -0800 [thread overview]
Message-ID: <1331313058.14217.16.camel@aeonflux> (raw)
In-Reply-To: <1331302710-29225-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> In L2CAP we use le16 format so change direction of conversion
> from le16_to_cpu to cpu_to_le16.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/l2cap_core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index cf0b166..eb72f5a 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -2413,9 +2413,9 @@ done:
> chan->remote_mps = size;
>
> rfc.retrans_timeout =
> - le16_to_cpu(L2CAP_DEFAULT_RETRANS_TO);
> + cpu_to_le16(L2CAP_DEFAULT_RETRANS_TO);
> rfc.monitor_timeout =
> - le16_to_cpu(L2CAP_DEFAULT_MONITOR_TO);
> + cpu_to_le16(L2CAP_DEFAULT_MONITOR_TO);
and here we should also use the __constant version.
Regards
Marcel
prev parent reply other threads:[~2012-03-09 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 14:18 [PATCH] Bluetooth: trivial: Fix endian conversion mode Andrei Emeltchenko
2012-03-09 17:10 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331313058.14217.16.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox