From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix broken usage of put_unaligned_le16
Date: Mon, 12 Mar 2012 10:31:46 -0700 [thread overview]
Message-ID: <1331573506.14217.79.camel@aeonflux> (raw)
In-Reply-To: <CAJdJm_PVtxF3qQY0+UWFr-6cXQFxXwXt4Qt4K6hZ5-FBNJ=0bw@mail.gmail.com>
Hi Anderson,
> > @@ -275,7 +275,7 @@ static int read_version(struct sock *sk, struct hci_dev *hdev, void *data,
> > BT_DBG("sock %p", sk);
> >
> > rp.version = MGMT_VERSION;
> > - put_unaligned_le16(MGMT_REVISION, &rp.revision);
> > + rp.revision = __constant_cpu_to_le16(MGMT_VERSION);
>
> Looks like a typo here: MGMT_VERSION -> MGMT_REVISION
yep, that is a stupid typo :(
Regards
Marcel
prev parent reply other threads:[~2012-03-12 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 2:43 [PATCH] Bluetooth: Fix broken usage of put_unaligned_le16 Marcel Holtmann
2012-03-12 10:34 ` Anderson Lizardo
2012-03-12 17:31 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331573506.14217.79.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox