From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1331573777.14217.81.camel@aeonflux> Subject: Re: [PATCH 4/4] Bluetooth: trivial: Remove sparse warnings From: Marcel Holtmann To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Date: Mon, 12 Mar 2012 10:36:17 -0700 In-Reply-To: <1331560774-10748-4-git-send-email-Andrei.Emeltchenko.news@gmail.com> References: <1331560774-10748-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1331560774-10748-4-git-send-email-Andrei.Emeltchenko.news@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, at least put the sparse warning in the commit message. > Signed-off-by: Andrei Emeltchenko > --- > net/bluetooth/mgmt.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index 06b5df3..5efca93 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -287,7 +287,7 @@ static int read_commands(struct sock *sk, struct hci_dev *hdev, void *data, > struct mgmt_rp_read_commands *rp; > u16 num_commands = ARRAY_SIZE(mgmt_commands); > u16 num_events = ARRAY_SIZE(mgmt_events); > - u16 *opcode; > + __le16 *opcode; > size_t rp_size; > int i, err; > > @@ -2601,7 +2601,7 @@ static int load_long_term_keys(struct sock *sk, struct hci_dev *hdev, > return 0; > } > > -struct mgmt_handler { > +static struct mgmt_handler { > int (*func) (struct sock *sk, struct hci_dev *hdev, void *data, > u16 data_len); > bool var_len; And this should be static const. Regards Marcel