Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com
Subject: Re: [PATCH 1/7] Parse config DeviceID string on bluetoothd startup
Date: Fri, 16 Mar 2012 08:51:03 -0700	[thread overview]
Message-ID: <1331913063.14217.148.camel@aeonflux> (raw)
In-Reply-To: <1331908913-10330-1-git-send-email-szymon.janc@tieto.com>

Hi Szymon,

> Instead of parsing config DeviceID string on sdp server startup, parse
> it in main while reading config file. This allow to store logical DID
> values in main_opts (instead of raw config string) and make use of them
> in bluetoothd code.
> ---
>  src/hcid.h         |    6 +++++-
>  src/main.c         |   20 +++++++++++++++++---
>  src/sdpd-server.c  |   19 ++++---------------
>  src/sdpd-service.c |   16 +++++++++-------
>  src/sdpd.h         |    5 ++---
>  5 files changed, 37 insertions(+), 29 deletions(-)
> 
> diff --git a/src/hcid.h b/src/hcid.h
> index e2eaf86..53b098a 100644
> --- a/src/hcid.h
> +++ b/src/hcid.h
> @@ -42,7 +42,11 @@ struct main_opts {
>  
>  	uint8_t		mode;
>  	uint8_t		discov_interval;
> -	char		deviceid[15]; /* FIXME: */
> +
> +	gboolean	did;

store the uint16_t did_source here. 0x0000 means off like it does for
the kernel.

> +	uint16_t	did_vendor;
> +	uint16_t	did_product;
> +	uint16_t	did_version;
>  };

Regards

Marcel



  parent reply	other threads:[~2012-03-16 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 14:41 [PATCH 1/7] Parse config DeviceID string on bluetoothd startup Szymon Janc
2012-03-16 14:41 ` [PATCH 2/7] Set DeviceID when registering adapter not when sdp server is starting Szymon Janc
2012-03-16 14:41 ` [PATCH 3/7] Add support for setting VID source (assigner ID) in DeviceID Szymon Janc
2012-03-16 14:41 ` [PATCH 4/7] mgmtops: Add support for setting Device ID Szymon Janc
2012-03-16 14:41 ` [PATCH 5/7] btmgmt: " Szymon Janc
2012-03-16 14:41 ` [PATCH 6/7] Bump Device ID service version to 1.3 Szymon Janc
2012-03-16 14:41 ` [PATCH 7/7] Move common code to sdp to avoid duplication Szymon Janc
2012-03-16 15:51 ` Marcel Holtmann [this message]
2012-03-16 16:02   ` [PATCH 1/7] Parse config DeviceID string on bluetoothd startup Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331913063.14217.148.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=kanak.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox