From: "Elvis Pfützenreuter" <epx@signove.com>
To: linux-bluetooth@vger.kernel.org
Cc: epx@signove.com
Subject: [PATCH] Fix crash when HDP first reliable channel is nil
Date: Fri, 16 Mar 2012 19:53:09 -0300 [thread overview]
Message-ID: <1331938389-4856-1-git-send-email-epx@signove.com> (raw)
Congruent to health_channel_destroy(), the "/" path is returned by MainChannel
property of HealthDevice when the first reliable channel is nil.
An empty path provokes the following error:
process xxxs: arguments to dbus_message_iter_append_basic() were incorrect,
assertion "_dbus_check_is_valid_path (*string_p)" failed in file
../../dbus/dbus-message.c line 2539. This is normally a bug in some
application using the D-Bus library.
---
health/hdp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/health/hdp.c b/health/hdp.c
index 812352f..eba438a 100644
--- a/health/hdp.c
+++ b/health/hdp.c
@@ -2077,7 +2077,7 @@ static DBusMessage *device_get_properties(DBusConnection *conn,
if (device->fr != NULL)
path = g_strdup(device->fr->path);
else
- path = g_strdup("");
+ path = g_strdup("/");
dict_append_entry(&dict, "MainChannel", DBUS_TYPE_OBJECT_PATH, &path);
g_free(path);
dbus_message_iter_close_container(&iter, &dict);
--
1.7.5.4
next reply other threads:[~2012-03-16 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 22:53 Elvis Pfützenreuter [this message]
2012-03-27 11:36 ` [PATCH] Fix crash when HDP first reliable channel is nil Johan Hedberg
2012-03-27 11:59 ` Elvis Pfutzenreuter
2012-03-27 12:18 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331938389-4856-1-git-send-email-epx@signove.com \
--to=epx@signove.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox