From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1332938784.1870.166.camel@aeonflux> Subject: Re: [PATCH] Bluetooth: Remove unneeded zero initialization From: Marcel Holtmann To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Date: Wed, 28 Mar 2012 14:46:24 +0200 In-Reply-To: <1332935794-15319-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> References: <1332935794-15319-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, > Remove zero initialization since channel is allocated with kzalloc > in l2cap_chan_create. > > Signed-off-by: Andrei Emeltchenko > --- > net/bluetooth/l2cap_sock.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c > index 53e563f..4e73b41 100644 > --- a/net/bluetooth/l2cap_sock.c > +++ b/net/bluetooth/l2cap_sock.c > @@ -999,7 +999,7 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent) > } > > chan->imtu = L2CAP_DEFAULT_MTU; > - chan->omtu = 0; > + while technically not needed. This seems like a good idea to keep from a visual point of view. > if (!disable_ertm && sk->sk_type == SOCK_STREAM) { > chan->mode = L2CAP_MODE_ERTM; > set_bit(CONF_STATE2_DEVICE, &chan->conf_state); > @@ -1011,7 +1011,6 @@ static void l2cap_sock_init(struct sock *sk, struct sock *parent) > chan->tx_win = L2CAP_DEFAULT_TX_WINDOW; > chan->tx_win_max = L2CAP_DEFAULT_TX_WINDOW; > chan->sec_level = BT_SECURITY_LOW; > - chan->flags = 0; This one can be removed indeed. > set_bit(FLAG_FORCE_ACTIVE, &chan->flags); > } > Regards Marcel