Re: [PATCH] btusb: typo in Broadcom SoftSailing id

[Marcel Holtmann <marcel@holtmann.org>]

Hi Don,

> I was trying to backport the following commit to RHEL-6
> 
>     From 0cea73465cd22373c5cd43a3edd25fbd4bb532ef Mon Sep 17 00:00:00 2001
>     From: Oliver Neukum <oliver@neukum.org>
>     Date: Wed, 21 Sep 2011 11:37:15 +0200
>     Subject: [PATCH] btusb: add device entry for Broadcom SoftSailing
> 
> and noticed it wasn't working on an HP Elitebook.  Looking into the patch I
> noticed a very subtle typo in the ids.  The patch has '0x05ac' instead of
> '0x0a5c'.  A snippet of the lsusb -v output also shows this:
> 
> Bus 002 Device 003: ID 0a5c:21e1 Broadcom Corp.
> Device Descriptor:
>   bLength                18
>   bDescriptorType         1
>   bcdUSB               2.00
>   bDeviceClass          255 Vendor Specific Class
>   bDeviceSubClass         1
>   bDeviceProtocol         1
>   bMaxPacketSize0        64
>   idVendor           0x0a5c Broadcom Corp.
>   idProduct          0x21e1
>   bcdDevice            1.12
>   iManufacturer           1 Broadcom Corp
>   iProduct                2 BCM20702A0
>   iSerial                 3 60D819F0338C
>   bNumConfigurations      1
> 
> Looking at other Broadcom ids, the fix matches them whereas the original patch
> matches Apple's ids.
> 
> Tested on an HP Elitebook 8760w.  The btusb binds and the userspace stuff loads
> correctly.
> 
> Cc: Oliver Neukum <oliver@neukum.org>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> ---
>  drivers/bluetooth/btusb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 789c9b5..86d9712 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -61,7 +61,7 @@ static struct usb_device_id btusb_table[] = {
>  	{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },
>  
>  	/* Broadcom SoftSailing reporting vendor specific */
> -	{ USB_DEVICE(0x05ac, 0x21e1) },
> +	{ USB_DEVICE(0x0a5c, 0x21e1) },

good catch. And this also should go into -stable as well.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel