* [PATCH] Bluetooth: Fix packet type for ESCO Link
@ 2012-04-03 9:46 Hemant Gupta
2012-04-03 12:51 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Hemant Gupta @ 2012-04-03 9:46 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Naresh Gupta, Hemant Gupta, Hemant Gupta
This patch fixes the packet type for ESCO Link which was incorrectly
set for EDR ESCO Packet Types.
Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
---
net/bluetooth/hci_conn.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 947172b..bff6bc1 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -396,7 +396,7 @@ struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst)
conn->pkt_type = hdev->pkt_type & SCO_PTYPE_MASK;
break;
case ESCO_LINK:
- conn->pkt_type = hdev->esco_type & ~EDR_ESCO_MASK;
+ conn->pkt_type = hdev->esco_type ^ ~EDR_ESCO_MASK;
break;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Fix packet type for ESCO Link
2012-04-03 9:46 [PATCH] Bluetooth: Fix packet type for ESCO Link Hemant Gupta
@ 2012-04-03 12:51 ` Marcel Holtmann
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2012-04-03 12:51 UTC (permalink / raw)
To: Hemant Gupta; +Cc: linux-bluetooth, Naresh Gupta, Hemant Gupta
Hi Hemant,
> This patch fixes the packet type for ESCO Link which was incorrectly
> set for EDR ESCO Packet Types.
>
> Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 947172b..bff6bc1 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -396,7 +396,7 @@ struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst)
> conn->pkt_type = hdev->pkt_type & SCO_PTYPE_MASK;
> break;
> case ESCO_LINK:
> - conn->pkt_type = hdev->esco_type & ~EDR_ESCO_MASK;
> + conn->pkt_type = hdev->esco_type ^ ~EDR_ESCO_MASK;
> break;
> }
>
please have a commit messages that actually describes the problem. I
honestly don't see what is broken and what you are trying to fix here.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Bluetooth: Fix packet type for ESCO Link
@ 2012-04-04 5:38 Hemant Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Hemant Gupta @ 2012-04-04 5:38 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Naresh Gupta, Hemant Gupta, Hemant Gupta
This patch uses the corect packet type for ESCO Link.
Without this patch esco packet types were anded with ~EDR_ESCO_MASK
resulting in setting bits that are not supported by controller
to 0 which means that corresponding EDR ESCO packet type is
supported(EDR Packet types are inverted as per BT Spec) which might
not be the case.
Signed-off-by: Hemant Gupta <hemant.gupta@stericsson.com>
---
net/bluetooth/hci_conn.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 947172b..1060fb6 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -396,7 +396,7 @@ struct hci_conn *hci_conn_add(struct hci_dev *hdev, int type, bdaddr_t *dst)
conn->pkt_type = hdev->pkt_type & SCO_PTYPE_MASK;
break;
case ESCO_LINK:
- conn->pkt_type = hdev->esco_type & ~EDR_ESCO_MASK;
+ conn->pkt_type = hdev->esco_type ^ EDR_ESCO_MASK;
break;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-04 5:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-03 9:46 [PATCH] Bluetooth: Fix packet type for ESCO Link Hemant Gupta
2012-04-03 12:51 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2012-04-04 5:38 Hemant Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).