From: Marcel Holtmann <marcel@holtmann.org>
To: Hemant Gupta <hemantgupta.ste@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org,
Hemant Gupta <hemant.gupta@stericsson.com>
Subject: Re: [PATCH v3] Bluetooth: Fix packet type for ESCO Link
Date: Thu, 05 Apr 2012 09:14:53 -0700 [thread overview]
Message-ID: <1333642493.16897.7.camel@aeonflux> (raw)
In-Reply-To: <CACj007nwsZumYtKkFcEu2jQa=f7dZJYJ=szXEMVhO0n5goRCjg@mail.gmail.com>
Hi Hemant,
> > This patch uses the corect packet type for ESCO Link.
> > Without this patch esco packet types were anded with ~EDR_ESCO_MASK
> > resulting in setting bits that are not supported by controller
> > to 0 which means that corresponding EDR ESCO packet type is
> > supported(EDR Packet types are inverted as per BT Spec) which might
> > not be the case.
> >
> Any comments on this patch ?
as I said before, I like to see a hcidump in the commit messages that
shows the failure.
Regards
Marcel
next prev parent reply other threads:[~2012-04-05 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 3:46 [PATCH v3] Bluetooth: Fix packet type for ESCO Link Hemant Gupta
2012-04-05 16:01 ` Hemant Gupta
2012-04-05 16:14 ` Marcel Holtmann [this message]
2012-04-05 16:47 ` Hemant Gupta
2012-04-05 17:46 ` Marcel Holtmann
2012-04-05 18:01 ` Hemant Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333642493.16897.7.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=hemant.gupta@stericsson.com \
--cc=hemantgupta.ste@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox