From: Marcel Holtmann <marcel@holtmann.org>
To: Mikel Astiz <mikel.astiz.oss@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: Re: [PATCH v0 3/6] Bluetooth: Remove unused HCI event handling
Date: Wed, 11 Apr 2012 11:23:20 +0200 [thread overview]
Message-ID: <1334136200.16897.97.camel@aeonflux> (raw)
In-Reply-To: <1334126932-27327-4-git-send-email-mikel.astiz.oss@gmail.com>
Hi Mikel,
> Function hci_num_comp_pkts_evt() doesn't need to handle SCO connections
> unless SCO flow control is explicitly enabled, as described in the
> Bluetooth Core Specification, Volume 4, Part B, section 7.7.19.
>
> Even in the unlikely case that the hardware supports this feature, the
> kernel does not enable it.
I am not sure that we should just remove this. What happens if you run
on a controller that has this enabled? I rather have the support for it
added then.
Regards
Marcel
next prev parent reply other threads:[~2012-04-11 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 6:48 [PATCH v0 0/6] Multiple Bluetooth SCO connections Mikel Astiz
2012-04-11 6:48 ` [PATCH v0 1/6] Bluetooth: Use unsigned int instead of signed int Mikel Astiz
2012-04-11 9:21 ` Marcel Holtmann
2012-04-13 21:59 ` Gustavo Padovan
2012-04-11 6:48 ` [PATCH v0 2/6] Bluetooth: Remove unnecessary check Mikel Astiz
2012-04-11 9:22 ` Marcel Holtmann
2012-04-13 22:01 ` Gustavo Padovan
2012-04-11 6:48 ` [PATCH v0 3/6] Bluetooth: Remove unused HCI event handling Mikel Astiz
2012-04-11 9:23 ` Marcel Holtmann [this message]
2012-04-11 15:27 ` Mikel Astiz
2012-04-11 6:48 ` [PATCH v0 4/6] Bluetooth: Simplify outgoing SCO scheduling code Mikel Astiz
2012-04-11 9:24 ` Marcel Holtmann
2012-04-11 11:43 ` Luiz Augusto von Dentz
2012-04-11 15:23 ` Mikel Astiz
2012-04-11 15:34 ` Marcel Holtmann
2012-04-12 5:58 ` Mikel Astiz
2012-04-12 9:52 ` Marcel Holtmann
2012-04-11 6:48 ` [PATCH v0 5/6] Bluetooth: btusb: Dynamic alternate setting Mikel Astiz
2012-04-11 9:26 ` Marcel Holtmann
2012-04-16 21:46 ` Gustavo Padovan
2012-04-17 9:26 ` Marcel Holtmann
2012-04-17 10:47 ` Gustavo Padovan
2012-04-11 6:48 ` [PATCH v0 6/6] Bluetooth: Remove outgoing MTU check Mikel Astiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334136200.16897.97.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz.oss@gmail.com \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).